runtime/vm/flow_graph_compiler_ia32.cc - Issue 685003002: Add missing StoreIntoObject calls in generated code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_compiler_ia32.cc

Issue 685003002: Add missing StoreIntoObject calls in generated code. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/flow_graph_compiler_ia32.cc

===================================================================

--- runtime/vm/flow_graph_compiler_ia32.cc (revision 41331)

+++ runtime/vm/flow_graph_compiler_ia32.cc (working copy)

@@ -8,6 +8,7 @@

#include "vm/flow_graph_compiler.h"

#include "vm/ast_printer.h"

+#include "vm/code_patcher.h"

#include "vm/compiler.h"

#include "vm/cpu.h"

#include "vm/dart_entry.h"

@@ -1193,8 +1194,12 @@

counter.SetAt(0, Smi::Handle(Smi::New(0)));

__ Comment("Edge counter");

__ LoadObject(EAX, counter);

- __ addl(FieldAddress(EAX, Array::element_offset(0)),

- Immediate(Smi::RawValue(1)));

+#if defined(DEBUG)

+ intptr_t increment_start = assembler_->CodeSize();

+#endif // DEBUG

+ __ IncrementSmiField(FieldAddress(EAX, Array::element_offset(0)), 1);

+ DEBUG_ASSERT((assembler_->CodeSize() - increment_start) ==

+ CodePatcher::EdgeCounterIncrementSizeInBytes());

}

« no previous file with comments | « runtime/vm/code_patcher_ia32.cc ('k') | runtime/vm/intrinsifier_ia32.cc » ('j') | runtime/vm/stub_code_ia32.cc » ('J')