Issue 684993006: Remove PhiReducer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 684993006: Remove PhiReducer. (Closed)

Created:
6 years, 1 month ago by titzer

Modified:
6 years, 1 month ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -276 lines)			Patch
M	BUILD.gn	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	src/compiler/phi-reducer.h	View	1 chunk	+0 lines, -43 lines	0 comments	Download
M	test/cctest/cctest.gyp	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	test/cctest/compiler/test-phi-reducer.cc	View	1 chunk	+0 lines, -230 lines	0 comments	Download
M	tools/gyp/v8.gyp	View	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

Michael Starzinger

LGTM. All red, that is an Instant-LGTM, just add boiling water and stir for a ...

6 years, 1 month ago (2014-11-11 11:59:48 UTC) #2

titzer

6 years, 1 month ago (2014-11-11 12:03:04 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 25262 (presubmit successful).