chrome/browser/favicon/favicon_handler.h - Issue 684983003: Add Observer in FaviconTabHelper

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/favicon/favicon_handler.h

Issue 684983003: Add Observer in FaviconTabHelper (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/favicon/favicon_handler.h

diff --git a/chrome/browser/favicon/favicon_handler.h b/chrome/browser/favicon/favicon_handler.h

index 46a507ebd6b9de5f264a824799d43a0cc82e6b19..71c49a43d1cad5af63ff8fd333e8f84c5516fba4 100644

--- a/chrome/browser/favicon/favicon_handler.h

+++ b/chrome/browser/favicon/favicon_handler.h

@@ -227,7 +227,7 @@ class FaviconHandler {

favicon_base::IconType icon_type);

// Sets the favicon's data.

sky 2014/10/30 03:34:31 update comment.

michaelbai 2014/10/30 19:22:50 Done.

- void SetFaviconOnActivePage(const std::vector<

+ gfx::Image SelectFaviconFrames(const std::vector<

favicon_base::FaviconRawBitmapResult>& favicon_bitmap_results);

void SetFaviconOnActivePage(const GURL& icon_url, const gfx::Image& image);