Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2404)

Unified Diff: chrome/browser/favicon/favicon_handler.h

Issue 684983003: Add Observer in FaviconTabHelper (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addresses comments and sync Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/favicon/favicon_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/favicon/favicon_handler.h
diff --git a/chrome/browser/favicon/favicon_handler.h b/chrome/browser/favicon/favicon_handler.h
index 46a507ebd6b9de5f264a824799d43a0cc82e6b19..55656a660b1f780fe776e7f1a7cd4d3e77f88618 100644
--- a/chrome/browser/favicon/favicon_handler.h
+++ b/chrome/browser/favicon/favicon_handler.h
@@ -148,11 +148,6 @@ class FaviconHandler {
// Returns true if the favicon should be saved.
virtual bool ShouldSaveFavicon(const GURL& url);
- // Notifies the driver that the favicon for the active entry was updated.
- // |icon_url_changed| is true if a favicon with a different icon URL has been
- // selected since the previous call to NotifyFaviconUpdated().
- virtual void NotifyFaviconUpdated(bool icon_url_changed);
-
private:
friend class TestFaviconHandler; // For testing
@@ -226,10 +221,15 @@ class FaviconHandler {
const gfx::Image& image,
favicon_base::IconType icon_type);
- // Sets the favicon's data.
- void SetFaviconOnActivePage(const std::vector<
- favicon_base::FaviconRawBitmapResult>& favicon_bitmap_results);
- void SetFaviconOnActivePage(const GURL& icon_url, const gfx::Image& image);
+ // Notifies |driver_| favicon available. See
+ // FaviconDriver::NotifyFaviconAvailable() for |is_active_favicon| in detail.
+ void NotifyFaviconAvailable(
+ const std::vector<favicon_base::FaviconRawBitmapResult>&
+ favicon_bitmap_results,
+ bool is_active_favicon);
+ void NotifyFaviconAvailable(const GURL& icon_url,
+ const gfx::Image& image,
+ bool is_active_favicon);
// Return the current candidate if any.
favicon::FaviconURL* current_candidate() {
« no previous file with comments | « no previous file | chrome/browser/favicon/favicon_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698