chrome/browser/favicon/favicon_handler_unittest.cc - Issue 684983003: Add Observer in FaviconTabHelper

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/favicon/favicon_handler_unittest.cc

Issue 684983003: Add Observer in FaviconTabHelper (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/favicon/favicon_handler_unittest.cc

diff --git a/chrome/browser/favicon/favicon_handler_unittest.cc b/chrome/browser/favicon/favicon_handler_unittest.cc

index bc5c27da52cff11e4523e441d7a4b124aaa0efe9..75559aa6c4870b1cad7290a7de1d142f50d1d384 100644

--- a/chrome/browser/favicon/favicon_handler_unittest.cc

+++ b/chrome/browser/favicon/favicon_handler_unittest.cc

@@ -343,7 +343,7 @@ class TestFaviconHandler : public FaviconHandler {

bool ShouldSaveFavicon(const GURL& url) override { return true; }

- void NotifyFaviconUpdated(bool icon_url_changed) override {

+ void NotifyFaviconUpdated(const GURL& icon_url) override {

++num_favicon_updates_;

}