Add Observer in FaviconTabHelper

components/favicon/core/favicon_driver.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_FAVICON_CORE_FAVICON_DRIVER_H_
 #define COMPONENTS_FAVICON_CORE_FAVICON_DRIVER_H_
 
 class GURL;
 
 namespace gfx {
 class Image;
 }
 
 // Interface that allows Favicon core code to interact with its driver (i.e.,
 // obtain information from it and give information to it). A concrete
 // implementation must be provided by the driver.
 class FaviconDriver {
  public:
 
   // Starts the download for the given favicon. When finished, the driver
   // will call OnDidDownloadFavicon() with the results.
   // Returns the unique id of the download request. The id will be passed
   // in OnDidDownloadFavicon().
   // Bitmaps with pixel sizes larger than |max_bitmap_size| are filtered out
   // from the bitmap results. If there are no bitmap results <=
   // |max_bitmap_size|, the smallest bitmap is resized to |max_bitmap_size| and
   // is the only result. A |max_bitmap_size| of 0 means unlimited.
   virtual int StartDownload(const GURL& url, int max_bitmap_size) = 0;
 
-  // Notifies the driver that the favicon for the active entry was updated.
-  // |icon_url_changed| is true if a favicon with a different icon URL has
-  // been selected since the previous call to NotifyFaviconUpdated().
-  virtual void NotifyFaviconUpdated(bool icon_url_changed) = 0;
-
   // Returns whether the user is operating in an off-the-record context.
   virtual bool IsOffTheRecord() = 0;
 
   // Returns the bitmap of the current page's favicon. Requires GetActiveURL()
   // to be valid.
   virtual const gfx::Image GetActiveFaviconImage() = 0;
 
   // Returns the URL of the current page's favicon. Requires GetActiveURL() to
   // be valid.
   virtual const GURL GetActiveFaviconURL() = 0;
 
   // Returns whether the page's favicon is valid (returns false if the default
   // favicon is being used). Requires GetActiveURL() to be valid.
   virtual bool GetActiveFaviconValidity() = 0;
 
   // Returns the URL of the current page, if any. Returns an invalid
   // URL otherwise.
   virtual const GURL GetActiveURL() = 0;
 
-  // Sets the bitmap of the current page's favicon. Requires GetActiveURL() to
-  // be valid.
-  virtual void SetActiveFaviconImage(gfx::Image image) = 0;
-
-  // Sets the URL of the favicon's bitmap. Requires GetActiveURL() to be valid.
-  virtual void SetActiveFaviconURL(GURL url) = 0;
-
-  // Sets whether the page's favicon is valid (if false, the default favicon is
-  // being used). Requires GetActiveURL() to be valid.
-  virtual void SetActiveFaviconValidity(bool validity) = 0;

[michaelbai, 2014/10/30 19:22:51]

Hey Scott, I am not sure these methods still needed or not, who should I add as
reviewer?

[blundell, 2014/10/31 06:53:42]

jif@ is the right person to answer this question.

[jif-google, 2014/10/31 12:05:18]

michaelbai>
Since GetActiveFaviconValidity is used in conditions, and that
SetActiveFaviconValidity is used to change the validity from false (the default
value) to true, I would say that they are.

What makes you think that they aren't needed anymore?

[michaelbai, 2014/10/31 15:57:56]

I don't know how you use the driver, this patch added OnFaviconAvailable()
method, and it seemed that SetActiveFaviconValidity() could be done in it,  see
the FaviconTabHelper::OnFaviconAvailable as example, also the other 2 methods
could be removed.

Did you implement FaviconDriver or use FaviconTableHelper in your code?

[jif-google, 2014/10/31 16:51:30]

Resolved offline.
The conclusion is: we can remove the methods.

+  // Notifies the driver favicon |image| is available to use. |icon_url| is
+  // image's url, |update_active_favicon| indicates whether updating active
+  // favicon is needed.
+  virtual void OnFaviconAvailable(const gfx::Image& image,

[sky, 2014/10/30 21:33:49]

You need to make it clear image is not necessarily the 16x16 image. Also, you
need to make it clear what update_active_favicon means.

[michaelbai, 2014/10/31 23:21:27]

Done.

+                                  const GURL& icon_url,
+                                  bool update_active_favicon) = 0;
 };
 
 #endif  // COMPONENTS_FAVICON_CORE_FAVICON_DRIVER_H_