Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 684973003: Cleanup: Move InstantRestrictedIDCache from chrome/common to chrome/renderer. (Closed)

Created:
6 years, 1 month ago by Lei Zhang
Modified:
6 years, 1 month ago
Reviewers:
samarth, Jered, kmadhusu
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Cleanup: Move InstantRestrictedIDCache from chrome/common to chrome/renderer. Nobody is using it from chrome/browser anymore. Committed: https://crrev.com/5fab0631cf446beb6a2f749b91a07637a53afea8 Cr-Commit-Position: refs/heads/master@{#302234}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -598 lines) Patch
M chrome/chrome_common.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_renderer.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/common/OWNERS View 1 chunk +0 lines, -3 lines 0 comments Download
D chrome/common/instant_restricted_id_cache.h View 1 chunk +0 lines, -165 lines 0 comments Download
D chrome/common/instant_restricted_id_cache_unittest.cc View 1 chunk +0 lines, -423 lines 0 comments Download
M chrome/renderer/OWNERS View 1 chunk +5 lines, -0 lines 0 comments Download
A + chrome/renderer/instant_restricted_id_cache.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/renderer/instant_restricted_id_cache_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/renderer/searchbox/searchbox.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Lei Zhang
This was added in r190052, but all the chrome/browser users are gone. While I have ...
6 years, 1 month ago (2014-10-29 02:09:34 UTC) #2
Lei Zhang
On 2014/10/29 02:09:34, Lei Zhang wrote: > This was added in r190052, but all the ...
6 years, 1 month ago (2014-10-30 06:37:23 UTC) #4
Jered
On 2014/10/30 06:37:23, Lei Zhang wrote: > On 2014/10/29 02:09:34, Lei Zhang wrote: > > ...
6 years, 1 month ago (2014-10-30 13:56:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/684973003/20001
6 years, 1 month ago (2014-10-31 06:05:52 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-10-31 06:47:19 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-10-31 06:47:54 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5fab0631cf446beb6a2f749b91a07637a53afea8
Cr-Commit-Position: refs/heads/master@{#302234}

Powered by Google App Engine
This is Rietveld 408576698