Issue 68493005: Constant-folding through HForceRepresentation fix.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 68493005: Constant-folding through HForceRepresentation fix. (Closed)

Created:
7 years, 1 month ago by Igor Sheludko

Modified:
7 years, 1 month ago

Reviewers:
Benedikt Meurer, mvstanton, Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Constant-folding through HForceRepresentation fix. Reverts changes in HValue::IsInteger32Constant() made in https://code.google.com/p/v8/source/detail?r=17787 R=bmeurer@chromium.org, mvstanton@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17863

Patch Set 2 : Review notes fixed. #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -19 lines)			Patch
M	src/hydrogen.cc	View	1	5 chunks	+12 lines, -9 lines	0 comments	Download
M	src/hydrogen-instructions.h	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/hydrogen-instructions.cc	View	1	2 chunks	+19 lines, -9 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Benedikt Meurer

Nice cleanup. LGTM, but wait for Michaels opinion on this one.

7 years, 1 month ago (2013-11-19 08:25:09 UTC) #2

mvstanton

One small nit, but lgtm. It's a good idea! --michael https://codereview.chromium.org/68493005/diff/1/src/hydrogen-instructions.cc File src/hydrogen-instructions.cc (right): https://codereview.chromium.org/68493005/diff/1/src/hydrogen-instructions.cc#newcode1328 ...

7 years, 1 month ago (2013-11-19 10:22:27 UTC) #3

Igor Sheludko

Committed patchset #2 manually as r17863 (presubmit successful).

7 years, 1 month ago (2013-11-19 11:41:11 UTC) #4

Igor Sheludko

7 years, 1 month ago (2013-11-19 11:43:35 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/68493005/diff/1/src/hydrogen-instructions.cc
File src/hydrogen-instructions.cc (right):

https://codereview.chromium.org/68493005/diff/1/src/hydrogen-instructions.cc#...
src/hydrogen-instructions.cc:1328: if ((c->HasNumberValue())) {
On 2013/11/19 10:22:28, mvstanton wrote:
> nit: remove extra parens

Done.

Expand Messages | Collapse Messages

Issue 68493005: Constant-folding through HForceRepresentation fix. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Review notes fixed. #

Messages