Issue 6849001: adding x86_64 to TC_ARCH

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6849001: adding x86_64 to TC_ARCH (Closed)

Created:
9 years, 8 months ago by Raja Aluri

Modified:
9 years, 7 months ago

Reviewers:
anush

CC:
chromium-os-reviews_chromium.org

Base URL:
ssh://gitrw.chromium.org:9222/dev-util.git@master

Visibility:
Public.

Description

adding x86_64 to TC_ARCH Change-Id: Iae09e86bfbe8444e14a7e63f9e50d171a67618cf BUG=13363 TEST=Manually built the chroot with this change. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=f763af5

Patch Set 1 #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	host/cros_choose_profile	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

anush

9 years, 8 months ago (2011-04-13 23:06:54 UTC) #2

LGTM

On Wed, Apr 13, 2011 at 3:51 PM, <aluri@chromium.org> wrote:

> Reviewers: anush,
>
> Description:
> adding x86_64 to TC_ARCH
>
> Change-Id: Iae09e86bfbe8444e14a7e63f9e50d171a67618cf
>
> BUG=13363
> TEST=Manually built the chroot with this change.
>
>
> Please review this at http://codereview.chromium.org/6849001/
>
> SVN Base: ssh://gitrw.chromium.org:9222/dev-util.git@master
>
> Affected files:
>  M host/cros_choose_profile
>
>
> Index: host/cros_choose_profile
> diff --git a/host/cros_choose_profile b/host/cros_choose_profile
> index
>
039752449a543fc34b26de14a7bc81a20fd6f04f..be433be9d4ab21432c5d727dfc6a4aa292454dff
> 100755
> --- a/host/cros_choose_profile
> +++ b/host/cros_choose_profile
> @@ -85,6 +85,9 @@ case "${TC_ARCH}" in
>   *86)
>     ARCH="x86"
>     ;;
> +  x86_64)
> +    ARCH="amd64"
> +    ;;
>   *)
>     error "Unable to determine ARCH from toolchain: ${BOARD_VARIANT}"
>     exit 1
>
>
>

Expand Messages | Collapse Messages