Issue 684893002: Change cast to String to cast to Symbol in heap-snapshot-generator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 684893002: Change cast to String to cast to Symbol in heap-snapshot-generator. (Closed)

Created:
6 years, 1 month ago by Dmitry Lomov (no reviews)

Modified:
6 years, 1 month ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

Change cast to String to cast to Symbol in heap-snapshot-generator. R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24959

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/heap-snapshot-generator.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

Dmitry Lomov (no reviews)

PTAL at this one-liner. Should be the last place where we call SetPropertyReference casting to ...

6 years, 1 month ago (2014-10-28 15:54:53 UTC) #1

Yang

On 2014/10/28 15:54:53, Dmitry Lomov (chromium) wrote: > PTAL at this one-liner. Should be the ...

6 years, 1 month ago (2014-10-28 16:28:27 UTC) #2

Dmitry Lomov (no reviews)

6 years, 1 month ago (2014-10-28 18:09:07 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as 24959 (presubmit successful).