Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(983)

Issue 684883002: Revert "Heap profiler clean-up: remove unused methods" (Closed)

Created:
6 years, 1 month ago by yurys
Modified:
6 years, 1 month ago
Reviewers:
Yang, loislo
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Revert "Heap profiler clean-up: remove unused methods" This reverts commit 63fd24a7c0782ccc3221803e3a2740f1e1b92ceb. Broke compilation on Mac. TBR=loislo@chromium.org, yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24948

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M src/heap-snapshot-generator.h View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
yurys
Committed patchset #1 (id:1) manually as 24948 (tree was closed).
6 years, 1 month ago (2014-10-28 15:12:19 UTC) #1
Yang
6 years, 1 month ago (2014-10-28 15:28:33 UTC) #2
Message was sent while issue was closed.
On 2014/10/28 15:12:19, yurys wrote:
> Committed patchset #1 (id:1) manually as 24948 (tree was closed).

lgtm.

Powered by Google App Engine
This is Rietveld 408576698