pkg/analysis_server/test/services/refactoring/rename_class_member_test.dart - Issue 684863003: Issue 21333. Constant names are not special anymore in the style guide (Dart version).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/test/services/refactoring/rename_class_member_test.dart

Issue 684863003: Issue 21333. Constant names are not special anymore in the style guide (Dart version). (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/test/services/refactoring/naming_conventions_test.dart ('k') | pkg/analysis_server/test/services/refactoring/rename_local_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/test/services/refactoring/rename_class_member_test.dart

diff --git a/pkg/analysis_server/test/services/refactoring/rename_class_member_test.dart b/pkg/analysis_server/test/services/refactoring/rename_class_member_test.dart

index d45a37de83b74f1b966c2948878471933fa360f4..d7b1626c05f51a73733dc479f048afc8210a785d 100644

--- a/pkg/analysis_server/test/services/refactoring/rename_class_member_test.dart

+++ b/pkg/analysis_server/test/services/refactoring/rename_class_member_test.dart

@@ -271,29 +271,6 @@ class A {

assertRefactoringStatusOK(refactoring.checkNewName());

}

- test_checkNewName_FieldElement_const() {

- indexTestUnit('''

-class A {

- static const int TEST = 0;

-''');

- createRenameRefactoringAtString('TEST =');

- // null

- refactoring.newName = null;

- assertRefactoringStatus(

- refactoring.checkNewName(),

- RefactoringProblemSeverity.FATAL,

- expectedMessage: "Constant name must not be null.");

- // not upper case

- refactoring.newName = 'newName';

- assertRefactoringStatus(

- refactoring.checkNewName(),

- RefactoringProblemSeverity.WARNING);

- // OK

- refactoring.newName = 'NEW_NAME';

- assertRefactoringStatusOK(refactoring.checkNewName());

- }

test_checkNewName_MethodElement() {

indexTestUnit('''

class A {