pkg/analysis_server/lib/src/services/refactoring/rename_unit_member.dart - Issue 684863003: Issue 21333. Constant names are not special anymore in the style guide (Dart version).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/refactoring/rename_unit_member.dart

Issue 684863003: Issue 21333. Constant names are not special anymore in the style guide (Dart version). (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/services/refactoring/rename_local.dart ('k') | pkg/analysis_server/test/services/refactoring/naming_conventions_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/services/refactoring/rename_unit_member.dart

diff --git a/pkg/analysis_server/lib/src/services/refactoring/rename_unit_member.dart b/pkg/analysis_server/lib/src/services/refactoring/rename_unit_member.dart

index 81a69bd551274da74c3a4c7566b6e34d2934d193..9a9d65e0483adaf913d3acafbf9e36d75b74294a 100644

--- a/pkg/analysis_server/lib/src/services/refactoring/rename_unit_member.dart

+++ b/pkg/analysis_server/lib/src/services/refactoring/rename_unit_member.dart

@@ -76,12 +76,7 @@ class RenameUnitMemberRefactoringImpl extends RenameRefactoringImpl {

RefactoringStatus checkNewName() {

RefactoringStatus result = super.checkNewName();

if (element is TopLevelVariableElement) {

- TopLevelVariableElement variable = element as TopLevelVariableElement;

- if (variable.isConst) {

- result.addStatus(validateConstantName(newName));

- } else {

- result.addStatus(validateVariableName(newName));

- }

+ result.addStatus(validateVariableName(newName));

}

if (element is FunctionElement) {

result.addStatus(validateFunctionName(newName));