tools/skp/page_sets/skia_baidu_desktop.py - Issue 684863002: Updated all page sets to capture new set of webpage archives

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/skp/page_sets/skia_baidu_desktop.py

Issue 684863002: Updated all page sets to capture new set of webpage archives (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Add waits for some pagesets Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/skp/page_sets/skia_baidu_desktop.py

diff --git a/tools/skp/page_sets/skia_baidu_desktop.py b/tools/skp/page_sets/skia_baidu_desktop.py

index df11d6c5c7be53763a851c65fc50d12f6181f909..c7baa24b7a83e1b8e4b7d335a0cc10afc182e1e5 100644

--- a/tools/skp/page_sets/skia_baidu_desktop.py

+++ b/tools/skp/page_sets/skia_baidu_desktop.py

@@ -18,12 +18,9 @@ class SkiaBuildbotDesktopPage(page_module.Page):

self.user_agent_type = 'desktop'

self.archive_data_file = 'data/skia_baidu_desktop.json'

- def RunSmoothness(self, action_runner):

- action_runner.ScrollElement()

def RunNavigateSteps(self, action_runner):

action_runner.NavigateToPage(self)

- action_runner.Wait(60)

+ action_runner.Wait(90)

class SkiaBaiduDesktopPageSet(page_set_module.PageSet):