Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 684863002: Updated all page sets to capture new set of webpage archives (Closed)

Created:
6 years, 1 month ago by rmistry
Modified:
6 years, 1 month ago
Reviewers:
borenet
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Updated all page sets to capture new set of webpage archives. Fixed the record_wpr retry mechanism in webpages_playback.py. Updated all page sets to remove the no longer needed RunSmoothness and RunNavigateSteps. Updated the key_silk_cases pagesets to point to a non svn location: * skia_fontwipe_desktop.py * skia_silkfinance_desktop.py Removed mercurynews, record_wpr was timing out because of a popup. Added back the following pagesets which were previously disabled but are now working again: * skia_cnn_nexus10.py * skia_wordpress_desktop.py * skia_transformice_nexus10.py BUG=skia:3049 Committed: https://skia.googlesource.com/skia/+/0ec28af1a7259ef0deec44bd3cba74aafc3c2ad1

Patch Set 1 : Initial upload #

Patch Set 2 : Fix more page sets #

Patch Set 3 : Fixes to retry mechanism #

Patch Set 4 : Delete rectangletransition pageset as well #

Patch Set 5 : Add waits for some pagesets #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -650 lines) Patch
D tools/skp/page_sets/other/FAILING-skia_cnn_nexus10.json View 1 chunk +0 lines, -17 lines 0 comments Download
D tools/skp/page_sets/other/FAILING-skia_wordpress_desktop.json View 1 chunk +0 lines, -17 lines 0 comments Download
A + tools/skp/page_sets/other/POPUP-skia_mercurynews_nexus10.json View 1 chunk +0 lines, -7 lines 0 comments Download
D tools/skp/page_sets/other/TIMINGOUT-skia_transformice_nexus10.json View 1 chunk +0 lines, -13 lines 0 comments Download
M tools/skp/page_sets/skia_amazon_desktop.py View 1 chunk +0 lines, -7 lines 0 comments Download
M tools/skp/page_sets/skia_androidpolice_nexus10.py View 1 chunk +0 lines, -7 lines 0 comments Download
M tools/skp/page_sets/skia_baidu_desktop.py View 1 chunk +1 line, -4 lines 0 comments Download
M tools/skp/page_sets/skia_blogger_desktop.py View 1 chunk +0 lines, -8 lines 0 comments Download
M tools/skp/page_sets/skia_booking_desktop.py View 1 chunk +0 lines, -7 lines 0 comments Download
M tools/skp/page_sets/skia_carsvg_desktop.py View 1 chunk +0 lines, -7 lines 0 comments Download
M tools/skp/page_sets/skia_chalkboard_desktop.py View 1 chunk +0 lines, -7 lines 0 comments Download
M tools/skp/page_sets/skia_cnet_nexus10.py View 1 chunk +0 lines, -7 lines 0 comments Download
A + tools/skp/page_sets/skia_cnn_nexus10.py View 1 chunk +6 lines, -13 lines 0 comments Download
M tools/skp/page_sets/skia_css3gradients_desktop.py View 1 chunk +0 lines, -7 lines 0 comments Download
M tools/skp/page_sets/skia_cuteoverload_nexus10.py View 1 chunk +0 lines, -7 lines 0 comments Download
M tools/skp/page_sets/skia_deviantart_nexus10.py View 1 chunk +0 lines, -7 lines 0 comments Download
M tools/skp/page_sets/skia_digg_nexus10.py View 1 chunk +0 lines, -7 lines 0 comments Download
M tools/skp/page_sets/skia_ebay_desktop.py View 1 chunk +0 lines, -7 lines 0 comments Download
M tools/skp/page_sets/skia_engadget_nexus10.py View 1 chunk +0 lines, -7 lines 0 comments Download
M tools/skp/page_sets/skia_espn_desktop.py View 1 chunk +0 lines, -7 lines 0 comments Download
M tools/skp/page_sets/skia_facebook_desktop.py View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M tools/skp/page_sets/skia_fontwipe_desktop.py View 2 chunks +1 line, -9 lines 0 comments Download
M tools/skp/page_sets/skia_forecastio_desktop.py View 1 chunk +0 lines, -7 lines 0 comments Download
M tools/skp/page_sets/skia_gamedeksiam_nexus10.py View 1 chunk +0 lines, -7 lines 0 comments Download
M tools/skp/page_sets/skia_gmailthread_desktop.py View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M tools/skp/page_sets/skia_googleblog_nexus10.py View 1 chunk +0 lines, -7 lines 0 comments Download
M tools/skp/page_sets/skia_googlecalendar_nexus10.py View 1 chunk +0 lines, -7 lines 0 comments Download
M tools/skp/page_sets/skia_googlehome_desktop.py View 1 chunk +0 lines, -7 lines 0 comments Download
M tools/skp/page_sets/skia_googleplus_desktop.py View 1 chunk +0 lines, -7 lines 0 comments Download
M tools/skp/page_sets/skia_googlespreadsheet_desktop.py View 1 chunk +0 lines, -7 lines 0 comments Download
M tools/skp/page_sets/skia_googlespreadsheetdashed_desktop.py View 2 chunks +3 lines, -10 lines 0 comments Download
M tools/skp/page_sets/skia_gspro_nexus10.py View 1 chunk +0 lines, -7 lines 0 comments Download
M tools/skp/page_sets/skia_gws_desktop.py View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M tools/skp/page_sets/skia_hsfi_nexus10.py View 1 chunk +0 lines, -7 lines 0 comments Download
M tools/skp/page_sets/skia_jsfiddlebigcar_desktop.py View 1 chunk +0 lines, -7 lines 0 comments Download
M tools/skp/page_sets/skia_jsfiddlehumperclip_desktop.py View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M tools/skp/page_sets/skia_linkedin_desktop.py View 1 chunk +0 lines, -7 lines 0 comments Download
M tools/skp/page_sets/skia_mapsvg_desktop.py View 1 chunk +0 lines, -7 lines 0 comments Download
D tools/skp/page_sets/skia_mercurynews_nexus10.py View 1 chunk +0 lines, -44 lines 0 comments Download
M tools/skp/page_sets/skia_mlb_nexus10.py View 1 chunk +0 lines, -7 lines 0 comments Download
M tools/skp/page_sets/skia_mobilenews_desktop.py View 1 chunk +0 lines, -7 lines 0 comments Download
M tools/skp/page_sets/skia_mozilla_nexus10.py View 1 chunk +0 lines, -7 lines 0 comments Download
M tools/skp/page_sets/skia_nofolo_nexus10.py View 1 chunk +0 lines, -7 lines 0 comments Download
M tools/skp/page_sets/skia_nytimes_nexus10.py View 1 chunk +0 lines, -7 lines 0 comments Download
D tools/skp/page_sets/skia_oldinboxapp_desktop.py View 1 chunk +0 lines, -45 lines 0 comments Download
M tools/skp/page_sets/skia_pinterest_desktop.py View 1 chunk +0 lines, -7 lines 0 comments Download
M tools/skp/page_sets/skia_pokemonwiki_desktop.py View 1 chunk +0 lines, -7 lines 0 comments Download
M tools/skp/page_sets/skia_pravda_nexus10.py View 1 chunk +0 lines, -7 lines 0 comments Download
M tools/skp/page_sets/skia_rectangletransition_desktop.py View 1 2 3 1 chunk +0 lines, -45 lines 0 comments Download
M tools/skp/page_sets/skia_sahadan_nexus10.py View 1 chunk +0 lines, -7 lines 0 comments Download
M tools/skp/page_sets/skia_samoasvg_desktop.py View 1 chunk +0 lines, -7 lines 0 comments Download
M tools/skp/page_sets/skia_sfgate_desktop.py View 1 chunk +0 lines, -7 lines 0 comments Download
A + tools/skp/page_sets/skia_silkfinance_desktop.py View 1 chunk +5 lines, -12 lines 0 comments Download
M tools/skp/page_sets/skia_slashdot_nexus10.py View 1 chunk +0 lines, -7 lines 0 comments Download
M tools/skp/page_sets/skia_techmeme_nexus10.py View 1 chunk +0 lines, -7 lines 0 comments Download
M tools/skp/page_sets/skia_tigersvg_desktop.py View 1 chunk +0 lines, -7 lines 0 comments Download
A + tools/skp/page_sets/skia_transformice_nexus10.py View 1 1 chunk +7 lines, -7 lines 0 comments Download
M tools/skp/page_sets/skia_twitter_desktop.py View 1 chunk +0 lines, -7 lines 0 comments Download
M tools/skp/page_sets/skia_ukwsj_nexus10.py View 1 chunk +0 lines, -7 lines 0 comments Download
M tools/skp/page_sets/skia_vnexpress_nexus10.py View 1 chunk +0 lines, -7 lines 0 comments Download
M tools/skp/page_sets/skia_weather_desktop.py View 1 chunk +0 lines, -7 lines 0 comments Download
M tools/skp/page_sets/skia_wikipedia_galaxynexus.py View 1 chunk +0 lines, -7 lines 0 comments Download
A + tools/skp/page_sets/skia_wordpress_desktop.py View 1 chunk +7 lines, -13 lines 0 comments Download
M tools/skp/page_sets/skia_wowwiki_desktop.py View 1 chunk +0 lines, -7 lines 0 comments Download
M tools/skp/page_sets/skia_yahooanswers_desktop.py View 1 chunk +0 lines, -7 lines 0 comments Download
M tools/skp/page_sets/skia_youtube_desktop.py View 1 chunk +0 lines, -7 lines 0 comments Download
D tools/skp/page_sets/skia_youtubetvvideo_desktop.py View 1 chunk +0 lines, -44 lines 0 comments Download
M tools/skp/webpages_playback.py View 1 2 3 chunks +6 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
rmistry
6 years, 1 month ago (2014-10-28 19:08:13 UTC) #2
borenet
Rubber stamp LGTM
6 years, 1 month ago (2014-10-28 19:17:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/684863002/80001
6 years, 1 month ago (2014-10-28 21:15:31 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-10-28 21:25:24 UTC) #6
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) as 0ec28af1a7259ef0deec44bd3cba74aafc3c2ad1

Powered by Google App Engine
This is Rietveld 408576698