Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 684833002: Initialize SVGStaticStringLists with correct animated type. (Closed)

Created:
6 years, 1 month ago by reni
Modified:
6 years, 1 month ago
Reviewers:
fs, kouhei (in TOK)
CC:
blink-reviews, ed+blinkwatch_opera.com, shans, rjwright, Mike Lawther (Google), blink-reviews-animation_chromium.org, rwlbuis, fs, kouhei+svg_chromium.org, dstockwell, Timothy Loh, krit, f(malita), gyuyoung.kim_webkit.org, darktears, Stephen Chennney, Steve Block, pdr+svgwatchlist_chromium.org, Eric Willigers
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Initialize SVGStaticStringLists with correct animated type. Until now, SVGStaticStringLists were initialized with AnimatedStringList animated type. This was the reason why SVG test attributes - with SVGStaticStringList type - were considered as valid animatable attributes and why we ran into a crash later. This patch initializes SVGStaticStringLists with AnimatedUnknown type to avoid any attempts to animate them later. R=fs@opera.com,kouhei@chromium.org BUG=427866 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184567

Patch Set 1 #

Patch Set 2 : Update according to fs's suggestion. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -1 line) Patch
A LayoutTests/svg/animations/animate-test-attributes-crash.html View 1 chunk +15 lines, -0 lines 0 comments Download
A LayoutTests/svg/animations/animate-test-attributes-crash-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/svg/SVGStaticStringList.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
reni
6 years, 1 month ago (2014-10-28 17:38:47 UTC) #1
fs
LGTM (obviously =)). Please allow kouhei a look as well.
6 years, 1 month ago (2014-10-28 20:13:29 UTC) #2
kouhei (in TOK)
lgtm. Thanks for the fix!
6 years, 1 month ago (2014-10-29 06:12:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/684833002/20001
6 years, 1 month ago (2014-10-29 06:12:38 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-10-29 06:45:33 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 184567

Powered by Google App Engine
This is Rietveld 408576698