ProfileSyncServiceTest refactoring

chrome/browser/sync/glue/sync_backend_host_impl_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync/glue/sync_backend_host_impl.h"
 
 #include <cstddef>
 
+#include "base/file_util.h"
 #include "base/location.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop/message_loop.h"
 #include "base/synchronization/waitable_event.h"
 #include "base/test/test_timeouts.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/invalidation/invalidator_storage.h"
 #include "chrome/browser/prefs/pref_service_syncable.h"
 #include "chrome/browser/sync/glue/device_info.h"
 #include "chrome/browser/sync/glue/sync_frontend.h"
@@ skipping 661 matching lines @@
 // Test that configuration on restart sends the proper GU source.
 TEST_F(SyncBackendHostTest, DownloadControlTypesRestart) {
   sync_prefs_->SetSyncSetupCompleted();
   fake_manager_factory_->set_progress_marker_types(enabled_types_);
   fake_manager_factory_->set_initial_sync_ended_types(enabled_types_);
   InitializeBackend(true);
   EXPECT_EQ(syncer::CONFIGURE_REASON_NEWLY_ENABLED_DATA_TYPE,
             fake_manager_->GetAndResetConfigureReason());
 }
 
+// It is SyncBackendHostCore responsibility to cleanup Sync Data folder if sync
+// setup hasn't been completed. This test ensures that cleanup happens.
+TEST_F(SyncBackendHostTest, TestStartupWithOldSyncData) {
+  const char* nonsense = "slon";
+  base::FilePath temp_directory =
+      profile_->GetPath().AppendASCII("Sync Data");
+  base::FilePath sync_file = temp_directory.AppendASCII("SyncData.sqlite3");
+  ASSERT_TRUE(file_util::CreateDirectory(temp_directory));
+  ASSERT_NE(-1, file_util::WriteFile(sync_file, nonsense, strlen(nonsense)));
+
+  InitializeBackend(true);

[rlarocque, 2013/11/13 18:58:35]

I think InitializeBackend() will instantiate a FakeSyncManager.  The
FakeSyncManager has no syncable::Directory.  So no one will bother to create an
on-disk sync DB in this test.

I guess that's OK.  The test only promises to test the directory cleanup code,
and it certainly does that.

[pavely, 2013/11/18 19:26:57]

Yes, you are right. It doesn't test creation of sync db.

+
+  EXPECT_FALSE(base::PathExists(sync_file));
+}
+
 }  // namespace
 
 }  // namespace browser_sync