Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 684783004: Prefix CommandLine usage with base namespace (Part 4: ash/) (Closed)

Created:
6 years, 1 month ago by elecro
Modified:
6 years, 1 month ago
CC:
chromium-reviews, sadrul, derat+watch_chromium.org, tdanderson+overview_chromium.org, dcheng, oshima+watch_chromium.org, kalyank, stevenjb+watch_chromium.org, brettw
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Prefix CommandLine usage with base namespace (Part 4: ash/) Prefix all CommandLine usage in the ash/ directory with the base:: namespace. BUG=422426 Committed: https://crrev.com/d84534d316a5fa519123b3b04d5b39991fc2ef0e Cr-Commit-Position: refs/heads/master@{#301819}

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -47 lines) Patch
M ash/accelerators/accelerator_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/accelerators/debug_commands.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/accelerators/magnifier_key_scroller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/ash_touch_exploration_manager_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/audio/sounds.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/display/display_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/display/display_layout_store.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/display/display_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/display/mirror_window_controller_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/drag_drop/drag_drop_controller_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ash/host/ash_window_tree_host_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/root_window_controller.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M ash/root_window_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/shelf_layout_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/shelf_layout_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/shelf_view_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shell/content_client/shell_main_delegate.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ash/system/chromeos/power/tray_power.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/rotation/tray_rotation_lock_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray/system_tray_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray/tray_details_view_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/web_notification/web_notification_tray_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/test/ash_test_base.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/test/test_suite.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/touch/touch_observer_hud_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/app_list_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/lock_layout_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/maximize_mode/maximize_mode_controller.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ash/wm/maximize_mode/maximize_mode_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/overview/window_grid.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/overview/window_selector.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/power_button_controller.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/wm/system_modal_container_layout_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (4 generated)
elecro
Please take a look. skuhne@ for ash/system/,ash/wm/maximize_mode/ flackr@ for ash/wm/ oshima@ for ash/
6 years, 1 month ago (2014-10-28 17:06:03 UTC) #2
flackr
lgtm
6 years, 1 month ago (2014-10-28 17:57:57 UTC) #3
oshima
lgtm
6 years, 1 month ago (2014-10-28 18:58:26 UTC) #4
Mr4D (OOO till 08-26)
lgtm
6 years, 1 month ago (2014-10-28 20:35:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/684783004/1
6 years, 1 month ago (2014-10-29 10:31:54 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/75109) win_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/80147) android_chromium_gn_compile_dbg ...
6 years, 1 month ago (2014-10-29 10:35:57 UTC) #9
elecro
On 2014/10/29 10:35:57, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 1 month ago (2014-10-29 10:44:43 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/684783004/20001
6 years, 1 month ago (2014-10-29 10:46:08 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-10-29 12:34:40 UTC) #13
commit-bot: I haz the power
6 years, 1 month ago (2014-10-29 12:35:26 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d84534d316a5fa519123b3b04d5b39991fc2ef0e
Cr-Commit-Position: refs/heads/master@{#301819}

Powered by Google App Engine
This is Rietveld 408576698