Resolve enum value collision on UseCounter.h

Resolve enum value collision on UseCounter.h

r184341 and r184316 both added a new use counter with enum value 574.
This CL resolves the collision.

BUG=None

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184534

[kouhei (in TOK), 2014-10-28 10:27:57]

kouhei@chromium.org changed reviewers:
+ haraken@chromium.org, leviw@chromium.org, philipj@opera.com

[haraken, 2014-10-28 10:29:11]

LGTM

We should consider auto-generating UseCounter.h from an .in file.

[kouhei (in TOK), 2014-10-28 10:30:14]

The CQ bit was checked by kouhei@chromium.org

[commit-bot: I haz the power, 2014-10-28 10:30:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/684783003/1

[philipj_slow, 2014-10-28 10:31:41]

On 2014/10/28 10:29:11, haraken wrote:
> LGTM
> 
> We should consider auto-generating UseCounter.h from an .in file.

There are gaps where entries have been removed, how would that be represented?

LGTM.

[sof, 2014-10-28 10:37:07]

https://codereview.chromium.org/684783003/diff/1/Source/core/frame/UseCounter.h
File Source/core/frame/UseCounter.h (right):

https://codereview.chromium.org/684783003/diff/1/Source/core/frame/UseCounter...
Source/core/frame/UseCounter.h:547: WindowPostMessage = 575,
It would have been "more correct" to move RenderRuby down & renumber it, as it
was landed later.

[kouhei (in TOK), 2014-10-28 10:38:46]

The CQ bit was unchecked by kouhei@chromium.org

[kouhei (in TOK), 2014-10-28 10:39:52]

On 2014/10/28 10:37:07, sof wrote:
>
https://codereview.chromium.org/684783003/diff/1/Source/core/frame/UseCounter.h
> File Source/core/frame/UseCounter.h (right):
> 
>
https://codereview.chromium.org/684783003/diff/1/Source/core/frame/UseCounter...
> Source/core/frame/UseCounter.h:547: WindowPostMessage = 575,
> It would have been "more correct" to move RenderRuby down & renumber it, as it
> was landed later.

Done.

[kouhei (in TOK), 2014-10-28 10:40:06]

The CQ bit was checked by kouhei@chromium.org

[commit-bot: I haz the power, 2014-10-28 10:40:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/684783003/20001

[sof, 2014-10-28 10:41:39]

On 2014/10/28 10:39:52, kouhei wrote:
> On 2014/10/28 10:37:07, sof wrote:
> >
>
https://codereview.chromium.org/684783003/diff/1/Source/core/frame/UseCounter.h
> > File Source/core/frame/UseCounter.h (right):
> > 
> >
>
https://codereview.chromium.org/684783003/diff/1/Source/core/frame/UseCounter...
> > Source/core/frame/UseCounter.h:547: WindowPostMessage = 575,
> > It would have been "more correct" to move RenderRuby down & renumber it, as
it
> > was landed later.
> 
> Done.

thanks, lgtm.

[philipj_slow, 2014-10-28 10:45:19]

Why is there an extra blank line between these? You didn't add it, but you
preserved it :)

[kouhei (in TOK), 2014-10-28 10:47:04]

On 2014/10/28 10:45:19, philipj wrote:
> Why is there an extra blank line between these? You didn't add it, but you
> preserved it :)
Removed it :)

[kouhei (in TOK), 2014-10-28 11:07:04]

The CQ bit was checked by kouhei@chromium.org

[commit-bot: I haz the power, 2014-10-28 11:08:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/684783003/60001

[commit-bot: I haz the power, 2014-10-28 13:35:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-28 13:35:54]

Try jobs failed on following builders:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/33937)

[kouhei (in TOK), 2014-10-28 13:48:16]

The CQ bit was checked by kouhei@chromium.org

[commit-bot: I haz the power, 2014-10-28 13:49:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/684783003/60001

[commit-bot: I haz the power, 2014-10-28 14:53:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-28 14:53:39]

Failed to apply patch for Source/core/frame/UseCounter.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/frame/UseCounter.h
  Hunk #1 FAILED at 542.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/core/frame/UseCounter.h.rej

Patch:       Source/core/frame/UseCounter.h
Index: Source/core/frame/UseCounter.h
diff --git a/Source/core/frame/UseCounter.h b/Source/core/frame/UseCounter.h
index
e86def6ec4f9d1960bbdf4e3e0bdcee56a72322a..37d396144679574b559d1b53129cf7e54dfb1b3c
100644
--- a/Source/core/frame/UseCounter.h
+++ b/Source/core/frame/UseCounter.h
@@ -542,10 +542,9 @@ public:
         QuotedAnimationName = 571,
         QuotedKeyframesRule = 572,
         SrcsetDroppedCandidate = 573,
-        RenderRuby = 574,
-
         WindowPostMessage = 574,
         WindowPostMessageWithLegacyTargetOriginArgument = 575,
+        RenderRuby = 576,
 
         // Add new features immediately above this line. Don't change assigned
         // numbers of any item, and don't reuse removed slots.

[commit-bot: I haz the power, 2014-10-28 14:53:49]

The CQ bit was unchecked by commit-bot@chromium.org

[kouhei (in TOK), 2014-10-28 15:22:01]

The CQ bit was checked by kouhei@chromium.org

[commit-bot: I haz the power, 2014-10-28 15:22:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/684783003/80001

[commit-bot: I haz the power, 2014-10-28 16:35:39]

Committed patchset #5 (id:80001) as 184534

[leviw_travelin_and_unemployed, 2014-10-28 16:58:40]

leviw@chromium.org changed reviewers:
+ sigbjornf@opera.com

[leviw_travelin_and_unemployed, 2014-10-28 16:58:40]

D'oh! Thanks for fixing this.