Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 684763005: FFmpeg: Only use LazyInstance at global scope (Closed)

Created:
6 years, 1 month ago by dmichael (off chromium)
Modified:
6 years, 1 month ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

FFmpeg: Only use LazyInstance at global scope BUG=429131 R=dalecurtis@google.com Committed: https://crrev.com/db63c83a25ec7ed06e4e950b24e241bf5adb9005 Cr-Commit-Position: refs/heads/master@{#302319}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Use g_ for global variable name #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M media/filters/ffmpeg_glue.cc View 1 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
dmichael (off chromium)
6 years, 1 month ago (2014-10-31 16:11:21 UTC) #1
DaleCurtis
lgtm
6 years, 1 month ago (2014-10-31 18:16:22 UTC) #3
DaleCurtis
https://codereview.chromium.org/684763005/diff/1/media/filters/ffmpeg_glue.cc File media/filters/ffmpeg_glue.cc (right): https://codereview.chromium.org/684763005/diff/1/media/filters/ffmpeg_glue.cc#newcode121 media/filters/ffmpeg_glue.cc:121: static base::LazyInstance<FFmpegInitializer>::Leaky lazy_instance = g_ffmpeg_initializer ?
6 years, 1 month ago (2014-10-31 18:20:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/684763005/20001
6 years, 1 month ago (2014-10-31 19:32:39 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-10-31 20:43:41 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-10-31 20:44:24 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/db63c83a25ec7ed06e4e950b24e241bf5adb9005
Cr-Commit-Position: refs/heads/master@{#302319}

Powered by Google App Engine
This is Rietveld 408576698