Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Unified Diff: tools/telemetry/telemetry/core/platform/linux_based_platform_backend_unittest.py

Issue 684713003: Telemetry: Linux-based backends should return CPU results in seconds, not jiffies. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: update android test Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/core/platform/linux_based_platform_backend_unittest.py
diff --git a/tools/telemetry/telemetry/core/platform/linux_based_platform_backend_unittest.py b/tools/telemetry/telemetry/core/platform/linux_based_platform_backend_unittest.py
index dfadac3d31b596646c3dcf939306d4fa908e866f..d227e300d3642d50661aa7a6c9ee2e68c82a5ea4 100644
--- a/tools/telemetry/telemetry/core/platform/linux_based_platform_backend_unittest.py
+++ b/tools/telemetry/telemetry/core/platform/linux_based_platform_backend_unittest.py
@@ -23,21 +23,45 @@ class TestBackend(linux_based_platform_backend.LinuxBasedPlatformBackend):
def GetFileContents(self, filename):
return self._mock_files[filename]
+ def GetClockTicks(self):
+ return 41
+
class LinuxBasedPlatformBackendTest(unittest.TestCase):
+ def SetMockFileInBackend(self, backend, real_file, mock_file):
+ with open(os.path.join(util.GetUnittestDataDir(), real_file)) as f:
+ backend.SetMockFile(mock_file, f.read())
+
+ def testGetCpuStatsBasic(self):
+ if not linux_based_platform_backend.resource:
+ logging.warning('Test not supported')
+ return
+
+ backend = TestBackend()
+ self.SetMockFileInBackend(backend, 'stat', '/proc/1/stat')
+ result = backend.GetCpuStats(1)
+ self.assertEquals(result, {'CpuProcessTime': 22.0})
+
+ def testGetCpuTimestampBasic(self):
+ if not linux_based_platform_backend.resource:
+ logging.warning('Test not supported')
+ return
+
+ backend = TestBackend()
+ self.SetMockFileInBackend(backend, 'timer_list', '/proc/timer_list')
+ result = backend.GetCpuTimestamp()
+ self.assertEquals(result, {'TotalTime': 105054633.0})
+
def testGetMemoryStatsBasic(self):
if not linux_based_platform_backend.resource:
logging.warning('Test not supported')
return
backend = TestBackend()
- with open(os.path.join(util.GetUnittestDataDir(), 'stat')) as f:
- backend.SetMockFile('/proc/1/stat', f.read())
- with open(os.path.join(util.GetUnittestDataDir(), 'status')) as f:
- backend.SetMockFile('/proc/1/status', f.read())
- with open(os.path.join(util.GetUnittestDataDir(), 'smaps')) as f:
- backend.SetMockFile('/proc/1/smaps', f.read())
+ self.SetMockFileInBackend(backend, 'stat', '/proc/1/stat')
+ self.SetMockFileInBackend(backend, 'status', '/proc/1/status')
+ self.SetMockFileInBackend(backend, 'smaps', '/proc/1/smaps')
result = backend.GetMemoryStats(1)
self.assertEquals(result, {'PrivateDirty': 5324800,
'VM': 1025978368,
@@ -51,12 +75,9 @@ class LinuxBasedPlatformBackendTest(unittest.TestCase):
return
backend = TestBackend()
- with open(os.path.join(util.GetUnittestDataDir(), 'stat')) as f:
- backend.SetMockFile('/proc/1/stat', f.read())
- with open(os.path.join(util.GetUnittestDataDir(), 'status_nohwm')) as f:
- backend.SetMockFile('/proc/1/status', f.read())
- with open(os.path.join(util.GetUnittestDataDir(), 'smaps')) as f:
- backend.SetMockFile('/proc/1/smaps', f.read())
+ self.SetMockFileInBackend(backend, 'stat', '/proc/1/stat')
+ self.SetMockFileInBackend(backend, 'status_nohwm', '/proc/1/status')
+ self.SetMockFileInBackend(backend, 'smaps', '/proc/1/smaps')
result = backend.GetMemoryStats(1)
self.assertEquals(result, {'PrivateDirty': 5324800,
'VM': 1025978368,
« no previous file with comments | « tools/telemetry/telemetry/core/platform/linux_based_platform_backend.py ('k') | tools/telemetry/unittest_data/timer_list » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698