Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 684693002: Revert "[turbofan] Merge GenericNode with Node." (Closed)

Created:
6 years, 1 month ago by Jarin
Modified:
6 years, 1 month ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Revert "[turbofan] Merge GenericNode with Node." This reverts commit a238443c00ebbd8afb48ee7ad336e0ff163c84b5 (r24915) for tanking benchmarks. TBR=mstarzinger@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=24916

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+433 lines, -594 lines) Patch
M BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/generic-algorithm.h View 2 chunks +6 lines, -5 lines 0 comments Download
M src/compiler/generic-algorithm-inl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/generic-graph.h View 1 chunk +4 lines, -3 lines 0 comments Download
A src/compiler/generic-node.h View 1 chunk +279 lines, -0 lines 0 comments Download
A + src/compiler/generic-node-inl.h View 11 chunks +82 lines, -99 lines 0 comments Download
M src/compiler/graph.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/graph-builder.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/graph-visualizer.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/instruction.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/instruction-selector-impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-context-specialization.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-inlining.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-intrinsic-builder.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/machine-operator-reducer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/node.h View 2 chunks +18 lines, -253 lines 0 comments Download
M src/compiler/node.cc View 3 chunks +2 lines, -226 lines 0 comments Download
M src/compiler/node-cache.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M src/compiler/node-matchers.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/node-properties-inl.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/phi-reducer.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/simplified-operator-reducer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/value-numbering-reducer.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/compiler/codegen-tester.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/compiler/test-basic-block-profiler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/compiler/test-branch-combine.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/compiler/test-changes-lowering.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/compiler/test-graph-reducer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/compiler/test-linkage.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/compiler/test-node.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/compiler/test-node-algorithm.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-run-machops.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/compiler/test-schedule.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/compiler/test-scheduler.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-simplified-lowering.cc View 1 chunk +1 line, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Jarin
Committed patchset #1 (id:1) manually as 24916 (tree was closed).
6 years, 1 month ago (2014-10-27 22:34:30 UTC) #1
Michael Starzinger
6 years, 1 month ago (2014-10-28 11:22:32 UTC) #2
Message was sent while issue was closed. 
LGTM (rubber-stamped).

Powered by Google App Engine
This is Rietveld 408576698