Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 684653008: Revert of Temporarily excluding failing test on valgrind/drmemory bots (Closed)

Created:
6 years, 1 month ago by lanwei
Modified:
6 years, 1 month ago
Reviewers:
oshima
CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src@master
Project:
chromium
Visibility:
Public.

Description

Revert of Temporarily excluding failing test on valgrind/drmemory bots (patchset #1 id:20001 of https://codereview.chromium.org/680183003/) Reason for revert: We fixed the GestureRecognizerTest.GestureEventSmallPinchEnabled unit test, and now we can put it back. Original issue's description: > Temporarily excluding failing test on valgrind/drmemory bots > > BUG=427729 > TBR=lanwei@chromium.org > > Committed: https://crrev.com/d68b16491c7ff220905b2c5d2702f68d5387ddd9 > Cr-Commit-Position: refs/heads/master@{#301494} TBR=oshima@chromium.org NOTREECHECKS=true NOTRY=true BUG=427729 Committed: https://crrev.com/9e89b603955e15b8f4ac101bcd5750a886506d4d Cr-Commit-Position: refs/heads/master@{#303243}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M tools/valgrind/gtest_exclude/aura_unittests.gtest.txt View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
lanwei
Created Revert of Temporarily excluding failing test on valgrind/drmemory bots
6 years, 1 month ago (2014-11-07 15:52:48 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/684653008/1
6 years, 1 month ago (2014-11-07 15:52:56 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 1 month ago (2014-11-07 15:52:57 UTC) #4
oshima
lgtm
6 years, 1 month ago (2014-11-07 16:38:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/684653008/1
6 years, 1 month ago (2014-11-07 16:42:37 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-07 16:44:01 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-11-07 16:44:49 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9e89b603955e15b8f4ac101bcd5750a886506d4d
Cr-Commit-Position: refs/heads/master@{#303243}

Powered by Google App Engine
This is Rietveld 408576698