Don't dllexport anonymous class GestureConfigurationAura

Don't dllexport anonymous class GestureConfigurationAura

BUG=82385
R=jdduke@chromium.org

Committed: https://chromium.googlesource.com/chromium/src/+/729385c695007d9c6c38d1e11b11a67ac7af10c6

[hans, 2014-10-27 23:16:39]

hans@chromium.org changed reviewers:
+ jdduke@chromium.org, lanwei@chromium.org

[hans, 2014-10-27 23:16:40]

Please take a look.

[jdduke (slow), 2014-10-27 23:58:41]

On 2014/10/27 23:16:40, hans wrote:
> Please take a look.

lgtm

[hans, 2014-10-27 23:59:30]

The CQ bit was checked by hans@chromium.org

[jdduke (slow), 2014-10-27 23:59:59]

On 2014/10/27 23:58:41, jdduke wrote:
> On 2014/10/27 23:16:40, hans wrote:
> > Please take a look.
> 
> lgtm

We may yet need to revert the preceding patch, so maybe hold off until tomorrow
to land? Unless a build is broken, that is.

[commit-bot: I haz the power, 2014-10-28 00:02:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/684643003/1

[hans, 2014-10-28 00:02:40]

On 2014/10/27 23:59:59, jdduke wrote:
> On 2014/10/27 23:58:41, jdduke wrote:
> > On 2014/10/27 23:16:40, hans wrote:
> > > Please take a look.
> > 
> > lgtm
> 
> We may yet need to revert the preceding patch, so maybe hold off until
tomorrow
> to land? Unless a build is broken, that is.

I do have broken builds, but it's not on the main waterfall.

Does my patch really make it harder to revert, though?

[jdduke (slow), 2014-10-28 00:08:13]

On 2014/10/28 00:02:40, hans wrote:
> On 2014/10/27 23:59:59, jdduke wrote:
> > On 2014/10/27 23:58:41, jdduke wrote:
> > > On 2014/10/27 23:16:40, hans wrote:
> > > > Please take a look.
> > > 
> > > lgtm
> > 
> > We may yet need to revert the preceding patch, so maybe hold off until
> tomorrow
> > to land? Unless a build is broken, that is.
> 
> I do have broken builds, but it's not on the main waterfall.
> 
> Does my patch really make it harder to revert, though?

Not really, I was thinking more of sheriffs wanting to one click revert. Landing
now is fine.

[lanwei, 2014-10-28 00:12:45]

On 2014/10/28 00:08:13, jdduke wrote:
> On 2014/10/28 00:02:40, hans wrote:
> > On 2014/10/27 23:59:59, jdduke wrote:
> > > On 2014/10/27 23:58:41, jdduke wrote:
> > > > On 2014/10/27 23:16:40, hans wrote:
> > > > > Please take a look.
> > > > 
> > > > lgtm
> > > 
> > > We may yet need to revert the preceding patch, so maybe hold off until
> > tomorrow
> > > to land? Unless a build is broken, that is.
> > 
> > I do have broken builds, but it's not on the main waterfall.
> > 
> > Does my patch really make it harder to revert, though?
> 
> Not really, I was thinking more of sheriffs wanting to one click revert.
Landing
> now is fine.

I think it is fine right now, oshima@ helped me exclude the unit test, 
https://codereview.chromium.org/680183003/
so if we can fix this unit test then everything will be fine.

[commit-bot: I haz the power, 2014-10-28 01:08:29]

Patchset 1 (id:??) landed as
https://crrev.com/729385c695007d9c6c38d1e11b11a67ac7af10c6
Cr-Commit-Position: refs/heads/master@{#301529}

[hans, 2014-10-28 01:08:30]

Committed patchset #1 (id:1) manually as
729385c695007d9c6c38d1e11b11a67ac7af10c6 (presubmit successful).