ash/shelf/overflow_bubble.h - Issue 684643002: Standardize usage of virtual/override/final specifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/shelf/overflow_bubble.h

Issue 684643002: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ash/shelf/overflow_bubble.h

diff --git a/ash/shelf/overflow_bubble.h b/ash/shelf/overflow_bubble.h

index c36339c847c9cdc35e5977f5cbb6b3935e10a47a..ad682e47683a45e3bd89040edcabbbbf2edba5e9 100644

--- a/ash/shelf/overflow_bubble.h

+++ b/ash/shelf/overflow_bubble.h

@@ -28,7 +28,7 @@ class OverflowBubble : public ui::EventHandler,

public views::WidgetObserver {

public:

OverflowBubble();

- virtual ~OverflowBubble();

+ ~OverflowBubble() override;

// Shows an bubble pointing to |anchor| with |shelf_view| as its content.

void Show(views::View* anchor, ShelfView* shelf_view);

@@ -47,11 +47,11 @@ class OverflowBubble : public ui::EventHandler,

void ProcessPressedEvent(ui::LocatedEvent* event);

// Overridden from ui::EventHandler:

- virtual void OnMouseEvent(ui::MouseEvent* event) override;

- virtual void OnTouchEvent(ui::TouchEvent* event) override;

+ void OnMouseEvent(ui::MouseEvent* event) override;

+ void OnTouchEvent(ui::TouchEvent* event) override;

// Overridden from views::WidgetObserver:

- virtual void OnWidgetDestroying(views::Widget* widget) override;

+ void OnWidgetDestroying(views::Widget* widget) override;

OverflowBubbleView* bubble_; // Owned by views hierarchy.

views::View* anchor_; // Owned by ShelfView.

« no previous file with comments | « ash/shelf/background_animator.h ('k') | ash/shelf/overflow_bubble_view.h » ('j') | no next file with comments »