Source/core/dom/RenderTreeBuilder.cpp - Issue 684633006: Reattach whitespace siblings only when needed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/RenderTreeBuilder.cpp

Issue 684633006: Reattach whitespace siblings only when needed (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/dom/RenderTreeBuilder.cpp

diff --git a/Source/core/dom/RenderTreeBuilder.cpp b/Source/core/dom/RenderTreeBuilder.cpp

index af6f95232c28e83e31fc9768bdeb2286fa016099..75b2f6f82eb1c14e699a04964369249bc6977d7c 100644

--- a/Source/core/dom/RenderTreeBuilder.cpp

+++ b/Source/core/dom/RenderTreeBuilder.cpp

@@ -120,6 +120,7 @@ void RenderTreeBuilderForElement::createRenderer()

{

ASSERT(rendererIsNeeded());

ASSERT(!m_node->renderer());

+ ASSERT(m_node->needsAttach());

Element* element = toElement(m_node);

RenderStyle& style = *m_style.get();

@@ -165,6 +166,7 @@ void RenderTreeBuilderForText::createRenderer()

{

ASSERT(rendererIsNeeded());

ASSERT(!m_node->renderer());

+ ASSERT(m_node->needsAttach());

Text* textNode = toText(m_node);

RenderObject* parentRenderer = this->parentRenderer();