Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Unified Diff: Source/core/dom/Node.cpp

Issue 684633006: Reattach whitespace siblings only when needed (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Text::reattachIfNeeded() Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/dom/Node.cpp
diff --git a/Source/core/dom/Node.cpp b/Source/core/dom/Node.cpp
index 60e09a205ed5da49f28b78bc9f696885e66f7f40..5e42cf490ce2d3dcdf190a990dc1435da5a866bb 100644
--- a/Source/core/dom/Node.cpp
+++ b/Source/core/dom/Node.cpp
@@ -953,16 +953,15 @@ void Node::detach(const AttachContext& context)
#endif
}
-void Node::reattachWhitespaceSiblings(Text* start)
+void Node::reattachWhitespaceSiblingsIfNeeded(Text* start)
{
for (Node* sibling = start; sibling; sibling = sibling->nextSibling()) {
if (sibling->isTextNode() && toText(sibling)->containsOnlyWhitespace()) {
bool hadRenderer = !!sibling->renderer();
- sibling->reattach();
- // If the reattach didn't toggle the visibility of the whitespace we don't
- // need to continue reattaching siblings since they won't toggle visibility
- // either.
- if (hadRenderer == !!sibling->renderer())
+ toText(sibling)->reattachIfNeeded();
+ // If sibling's renderer status didn't change we don't need to continue checking
+ // other siblings since their renderer status won't change either.
+ if (!!sibling->renderer() == hadRenderer)
return;
} else if (sibling->renderer()) {
return;

Powered by Google App Engine
This is Rietveld 408576698