Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Side by Side Diff: Source/core/dom/RenderTreeBuilder.h

Issue 684633006: Reattach whitespace siblings only when needed (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved.
6 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 6 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
7 * Copyright (C) 2011 Google Inc. All rights reserved. 7 * Copyright (C) 2011 Google Inc. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 27 matching lines...) Expand all
38 class RenderObject; 38 class RenderObject;
39 class RenderStyle; 39 class RenderStyle;
40 40
41 class RenderTreeBuilder { 41 class RenderTreeBuilder {
42 STACK_ALLOCATED(); 42 STACK_ALLOCATED();
43 public: 43 public:
44 RenderTreeBuilder(Node* node) 44 RenderTreeBuilder(Node* node)
45 : m_node(node) 45 : m_node(node)
46 , m_renderingParent(NodeRenderingTraversal::parent(node)) 46 , m_renderingParent(NodeRenderingTraversal::parent(node))
47 { 47 {
48 ASSERT(node->needsAttach());
49 ASSERT(node->document().inStyleRecalc()); 48 ASSERT(node->document().inStyleRecalc());
50 49
51 // FIXME: We should be able to ASSERT(node->inActiveDocument()) but chil drenChanged is called 50 // FIXME: We should be able to ASSERT(node->inActiveDocument()) but chil drenChanged is called
52 // before ChildNodeInsertionNotifier in ContainerNode's methods and some implementations 51 // before ChildNodeInsertionNotifier in ContainerNode's methods and some implementations
53 // will trigger a layout inside childrenChanged. 52 // will trigger a layout inside childrenChanged.
54 // Mainly HTMLTextAreaElement::childrenChanged calls HTMLTextFormControl Element::setSelectionRange 53 // Mainly HTMLTextAreaElement::childrenChanged calls HTMLTextFormControl Element::setSelectionRange
55 // which does an updateLayoutIgnorePendingStylesheets. 54 // which does an updateLayoutIgnorePendingStylesheets.
56 } 55 }
57 56
58 void createRendererIfNeeded(); 57 void createRendererIfNeeded();
(...skipping 28 matching lines...) Expand all
87 RenderTreeBuilderForText(Text* text) 86 RenderTreeBuilderForText(Text* text)
88 : RenderTreeBuilder(text) { } 87 : RenderTreeBuilder(text) { }
89 88
90 virtual void createRenderer() override final; 89 virtual void createRenderer() override final;
91 virtual bool rendererIsNeeded() const override final; 90 virtual bool rendererIsNeeded() const override final;
92 }; 91 };
93 92
94 } // namespace blink 93 } // namespace blink
95 94
96 #endif 95 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698