Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 684633002: [Chromoting] Cleanup Python code formatting in build-webapp.py. (Closed)

Created:
6 years, 1 month ago by garykac
Modified:
6 years, 1 month ago
Reviewers:
anandc, Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Chromoting] Cleanup Python code formatting in build-webapp.py. BUG= Committed: https://crrev.com/219928189079f06f34c25acffd2fa90768c1bf68 Cr-Commit-Position: refs/heads/master@{#302500}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -50 lines) Patch
M remoting/webapp/build-webapp.py View 10 chunks +51 lines, -50 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
garykac
6 years, 1 month ago (2014-10-27 21:35:11 UTC) #2
anandc
gpylint actually lists a fair amount of issues with this file. Not sure if we ...
6 years, 1 month ago (2014-10-27 21:49:42 UTC) #3
anandc
On 2014/10/27 21:49:42, anandc wrote: > gpylint actually lists a fair amount of issues with ...
6 years, 1 month ago (2014-10-27 23:45:16 UTC) #4
garykac
+jamiewalch
6 years, 1 month ago (2014-10-29 17:26:04 UTC) #6
Jamie
On 2014/10/29 17:26:04, garykac wrote: > +jamiewalch LGTM as far as it goes, but since ...
6 years, 1 month ago (2014-10-29 17:42:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/684633002/1
6 years, 1 month ago (2014-11-03 21:42:27 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-03 22:29:14 UTC) #10
commit-bot: I haz the power
6 years, 1 month ago (2014-11-03 22:30:01 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/219928189079f06f34c25acffd2fa90768c1bf68
Cr-Commit-Position: refs/heads/master@{#302500}

Powered by Google App Engine
This is Rietveld 408576698