chrome/browser/prefs/leveldb_pref_store_unittest.cc - Issue 684613002: Standardize usage of virtual/override/final specifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/prefs/leveldb_pref_store_unittest.cc

Issue 684613002: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/notifications/message_center_settings_controller_unittest.cc ('K') | « chrome/browser/prefs/incognito_mode_prefs_unittest.cc ('k') | chrome/browser/prefs/pref_model_associator_unittest.cc » ('j') | chrome/browser/prefs/pref_model_associator_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/prefs/leveldb_pref_store_unittest.cc

diff --git a/chrome/browser/prefs/leveldb_pref_store_unittest.cc b/chrome/browser/prefs/leveldb_pref_store_unittest.cc

index e29df526eced526a38edfab90a5963e15c9e1380..dbe29a5f813f9ba02bcc2e9807b0442801f31d3d 100644

--- a/chrome/browser/prefs/leveldb_pref_store_unittest.cc

+++ b/chrome/browser/prefs/leveldb_pref_store_unittest.cc

@@ -32,7 +32,7 @@ class MockReadErrorDelegate : public PersistentPrefStore::ReadErrorDelegate {

class LevelDBPrefStoreTest : public testing::Test {

protected:

- virtual void SetUp() override {

+ void SetUp() override {

ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());

ASSERT_TRUE(PathService::Get(chrome::DIR_TEST_DATA, &data_dir_));

@@ -40,9 +40,7 @@ class LevelDBPrefStoreTest : public testing::Test {

ASSERT_TRUE(PathExists(data_dir_));

}

- virtual void TearDown() override {

- Close();

- }

+ void TearDown() override { Close(); }

James Hawkins 2014/10/28 23:04:23 Undo this pull-up.

void Open() {

pref_store_ = new LevelDBPrefStore(