Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Side by Side Diff: chrome/browser/spellchecker/feedback_sender_unittest.cc

Issue 684613002: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Unit tests for |FeedbackSender| object. 5 // Unit tests for |FeedbackSender| object.
6 6
7 #include "chrome/browser/spellchecker/feedback_sender.h" 7 #include "chrome/browser/spellchecker/feedback_sender.h"
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/command_line.h" 10 #include "base/command_line.h"
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
59 } // namespace 59 } // namespace
60 60
61 // A test fixture to help keep tests simple. 61 // A test fixture to help keep tests simple.
62 class FeedbackSenderTest : public testing::Test { 62 class FeedbackSenderTest : public testing::Test {
63 public: 63 public:
64 FeedbackSenderTest() : ui_thread_(content::BrowserThread::UI, &loop_) { 64 FeedbackSenderTest() : ui_thread_(content::BrowserThread::UI, &loop_) {
65 feedback_.reset(new FeedbackSender(NULL, kLanguage, kCountry)); 65 feedback_.reset(new FeedbackSender(NULL, kLanguage, kCountry));
66 feedback_->StartFeedbackCollection(); 66 feedback_->StartFeedbackCollection();
67 } 67 }
68 68
69 virtual ~FeedbackSenderTest() {} 69 ~FeedbackSenderTest() override {}
70 70
71 protected: 71 protected:
72 // Appends the "--enable-spelling-service-feedback" switch to the 72 // Appends the "--enable-spelling-service-feedback" switch to the
73 // command-line. 73 // command-line.
74 void AppendCommandLineSwitch() { 74 void AppendCommandLineSwitch() {
75 // The command-line switch is temporary. 75 // The command-line switch is temporary.
76 // TODO(rouslan): Remove the command-line switch. http://crbug.com/247726 76 // TODO(rouslan): Remove the command-line switch. http://crbug.com/247726
77 CommandLine::ForCurrentProcess()->AppendSwitch( 77 CommandLine::ForCurrentProcess()->AppendSwitch(
78 switches::kEnableSpellingFeedbackFieldTrial); 78 switches::kEnableSpellingFeedbackFieldTrial);
79 feedback_.reset(new FeedbackSender(NULL, kLanguage, kCountry)); 79 feedback_.reset(new FeedbackSender(NULL, kLanguage, kCountry));
(...skipping 535 matching lines...) Expand 10 before | Expand all | Expand 10 after
615 AddPendingFeedback(); 615 AddPendingFeedback();
616 feedback_->OnReceiveDocumentMarkers(kRendererProcessId, 616 feedback_->OnReceiveDocumentMarkers(kRendererProcessId,
617 std::vector<uint32>()); 617 std::vector<uint32>());
618 feedback_->StartFeedbackCollection(); 618 feedback_->StartFeedbackCollection();
619 feedback_->OnReceiveDocumentMarkers(kRendererProcessId, 619 feedback_->OnReceiveDocumentMarkers(kRendererProcessId,
620 std::vector<uint32>()); 620 std::vector<uint32>());
621 EXPECT_FALSE(IsUploadingData()); 621 EXPECT_FALSE(IsUploadingData());
622 } 622 }
623 623
624 } // namespace spellcheck 624 } // namespace spellcheck
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698