Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 684603005: Cleanup: Fix actions.xml breakage. (Closed)

Created:
6 years, 1 month ago by tommycli
Modified:
6 years, 1 month ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Cleanup: Fix actions.xml breakage. BUG=NONE Committed: https://crrev.com/52636a1ef0071ac64f347674469f777f60ab3d4c Cr-Commit-Position: refs/heads/master@{#303166}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M tools/metrics/actions/actions.xml View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
tommycli
isherman: PTAL actions.xml in tip of tree no longer passes presubmit. I assume someone added ...
6 years, 1 month ago (2014-11-07 01:21:21 UTC) #2
Ilya Sherman
Oops! These are actually metrics that I added, but forgot to run the script for. ...
6 years, 1 month ago (2014-11-07 01:29:07 UTC) #3
Ilya Sherman
LGTM
6 years, 1 month ago (2014-11-07 01:29:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/684603005/20001
6 years, 1 month ago (2014-11-07 01:30:35 UTC) #6
tommycli
nice. thanks for quick response. i go home now :)
6 years, 1 month ago (2014-11-07 01:31:10 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-07 02:32:53 UTC) #8
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/52636a1ef0071ac64f347674469f777f60ab3d4c Cr-Commit-Position: refs/heads/master@{#303166}
6 years, 1 month ago (2014-11-07 02:34:32 UTC) #9
chromium-reviews
Were these from an HTML file and that's why our checks in the top-level PRESUBMIT.py ...
6 years, 1 month ago (2014-11-07 16:43:52 UTC) #10
Ilya Sherman
6 years, 1 month ago (2014-11-07 20:09:48 UTC) #11
Message was sent while issue was closed.
On 2014/11/07 16:43:52, chromium-reviews wrote:
> Were these from an HTML file and that's why our checks in the top-level
> PRESUBMIT.py didn't catch them? (If so, let's file a bug to track that.)

Yep, exactly.  I filed
https://code.google.com/p/chromium/issues/detail?id=431393

Powered by Google App Engine
This is Rietveld 408576698