chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_panel.cc - Issue 684563002: Standardize usage of virtual/override/final specifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_panel.cc

Issue 684563002: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_panel.h ('k') | chrome/browser/ui/views/apps/chrome_native_app_window_views.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_panel.cc

diff --git a/chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_panel.cc b/chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_panel.cc

index fae9adcb79267eedbeeb9440305679d8057c54c4..ceb430549d9c95086c2b41675b02ca2615ab26ec 100644

--- a/chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_panel.cc

+++ b/chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_panel.cc

@@ -36,14 +36,14 @@

class LaunchOptionsComboboxModel : public ui::ComboboxModel {

public:

LaunchOptionsComboboxModel();

- virtual ~LaunchOptionsComboboxModel();

+ ~LaunchOptionsComboboxModel() override;

extensions::LaunchType GetLaunchTypeAtIndex(int index) const;

int GetIndexForLaunchType(extensions::LaunchType launch_type) const;

// Overridden from ui::ComboboxModel:

- virtual int GetItemCount() const override;

- virtual base::string16 GetItemAt(int index) override;

+ int GetItemCount() const override;

+ base::string16 GetItemAt(int index) override;

private:

// A list of the launch types available in the combobox, in order.