chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views_unittest.cc - Issue 684563002: Standardize usage of virtual/override/final specifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views_unittest.cc

Issue 684563002: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.h ('k') | chrome/browser/ui/views/apps/app_info_dialog/app_info_footer_panel.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views_unittest.cc

diff --git a/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views_unittest.cc b/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views_unittest.cc

index 9697adbe0f0a19942b7bc0d8c305b13bf664c3a8..087170451fa7fc7b8f35300eda2b3c025c622052 100644

--- a/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views_unittest.cc

+++ b/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views_unittest.cc

@@ -37,10 +37,10 @@ class AppInfoDialogViewsTest : public ash::test::AshTestBase,

: widget_(NULL),

widget_destroyed_(false),

command_line_(CommandLine::NO_PROGRAM) {}

- virtual ~AppInfoDialogViewsTest() {}

+ ~AppInfoDialogViewsTest() override {}

// Overridden from testing::Test:

- virtual void SetUp() override {

+ void SetUp() override {

ash::test::AshTestBase::SetUp();

widget_ = views::DialogDelegate::CreateDialogWidget(

@@ -61,7 +61,7 @@ class AppInfoDialogViewsTest : public ash::test::AshTestBase,

widget_->GetContentsView()->AddChildView(dialog_);

}

- virtual void TearDown() override {

+ void TearDown() override {

if (!widget_destroyed_)

widget_->CloseNow();

widget_ = NULL;

@@ -71,7 +71,7 @@ class AppInfoDialogViewsTest : public ash::test::AshTestBase,

protected:

// Overridden from views::WidgetObserver:

- virtual void OnWidgetDestroyed(views::Widget* widget) override {

+ void OnWidgetDestroyed(views::Widget* widget) override {

widget_destroyed_ = true;

widget_->RemoveObserver(this);

widget_ = NULL;