components/policy/core/common/cloud/policy_header_service_unittest.cc - Issue 684513002: Standardize usage of virtual/override/final specifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/core/common/cloud/policy_header_service_unittest.cc

Issue 684513002: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/policy/core/common/cloud/policy_header_io_helper_unittest.cc ('k') | components/policy/core/common/cloud/user_cloud_policy_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/policy/core/common/cloud/policy_header_service_unittest.cc

diff --git a/components/policy/core/common/cloud/policy_header_service_unittest.cc b/components/policy/core/common/cloud/policy_header_service_unittest.cc

index 7b2ef53ff6d54f6040517585bdde6a9ca3ed5f7f..2903ec40268d5f68dd5d9bb2b9767d56cd9f8cf3 100644

--- a/components/policy/core/common/cloud/policy_header_service_unittest.cc

+++ b/components/policy/core/common/cloud/policy_header_service_unittest.cc

@@ -37,9 +37,9 @@ class PolicyHeaderServiceTest : public testing::Test {

PolicyHeaderServiceTest() {

task_runner_ = make_scoped_refptr(new base::TestSimpleTaskRunner());

}

- virtual ~PolicyHeaderServiceTest() {}

+ ~PolicyHeaderServiceTest() override {}

- virtual void SetUp() override {

+ void SetUp() override {

service_.reset(new PolicyHeaderService(kDMServerURL,

kPolicyVerificationKeyHash,

&user_store_,

@@ -47,7 +47,7 @@ class PolicyHeaderServiceTest : public testing::Test {

helper_ = service_->CreatePolicyHeaderIOHelper(task_runner_).Pass();

}

- virtual void TearDown() override {

+ void TearDown() override {

task_runner_->RunUntilIdle();

// Helper should outlive the service.

service_.reset();