Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Unified Diff: components/policy/core/browser/configuration_policy_pref_store_unittest.cc

Issue 684513002: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/policy/core/browser/configuration_policy_pref_store_unittest.cc
diff --git a/components/policy/core/browser/configuration_policy_pref_store_unittest.cc b/components/policy/core/browser/configuration_policy_pref_store_unittest.cc
index c1d3cfc314fc77f9af7d6aec67421e25bfeea7f8..c8a203669ed30ea2083e1d107cac6ac46f525661 100644
--- a/components/policy/core/browser/configuration_policy_pref_store_unittest.cc
+++ b/components/policy/core/browser/configuration_policy_pref_store_unittest.cc
@@ -39,7 +39,7 @@ namespace policy {
// Test cases for list-valued policy settings.
class ConfigurationPolicyPrefStoreListTest
: public ConfigurationPolicyPrefStoreTest {
- virtual void SetUp() override {
+ void SetUp() override {
handler_list_.AddHandler(
make_scoped_ptr<ConfigurationPolicyHandler>(new SimplePolicyHandler(
kTestPolicy, kTestPref, base::Value::TYPE_LIST)));
@@ -67,7 +67,7 @@ TEST_F(ConfigurationPolicyPrefStoreListTest, SetValue) {
// Test cases for string-valued policy settings.
class ConfigurationPolicyPrefStoreStringTest
: public ConfigurationPolicyPrefStoreTest {
- virtual void SetUp() override {
+ void SetUp() override {
handler_list_.AddHandler(
make_scoped_ptr<ConfigurationPolicyHandler>(new SimplePolicyHandler(
kTestPolicy, kTestPref, base::Value::TYPE_STRING)));
@@ -95,7 +95,7 @@ TEST_F(ConfigurationPolicyPrefStoreStringTest, SetValue) {
// Test cases for boolean-valued policy settings.
class ConfigurationPolicyPrefStoreBooleanTest
: public ConfigurationPolicyPrefStoreTest {
- virtual void SetUp() override {
+ void SetUp() override {
handler_list_.AddHandler(
make_scoped_ptr<ConfigurationPolicyHandler>(new SimplePolicyHandler(
kTestPolicy, kTestPref, base::Value::TYPE_BOOLEAN)));
@@ -139,7 +139,7 @@ TEST_F(ConfigurationPolicyPrefStoreBooleanTest, SetValue) {
// Test cases for integer-valued policy settings.
class ConfigurationPolicyPrefStoreIntegerTest
: public ConfigurationPolicyPrefStoreTest {
- virtual void SetUp() override {
+ void SetUp() override {
handler_list_.AddHandler(
make_scoped_ptr<ConfigurationPolicyHandler>(new SimplePolicyHandler(
kTestPolicy, kTestPref, base::Value::TYPE_INTEGER)));
@@ -167,7 +167,7 @@ TEST_F(ConfigurationPolicyPrefStoreIntegerTest, SetValue) {
class ConfigurationPolicyPrefStoreRefreshTest
: public ConfigurationPolicyPrefStoreTest {
protected:
- virtual void SetUp() override {
+ void SetUp() override {
ConfigurationPolicyPrefStoreTest::SetUp();
store_->AddObserver(&observer_);
handler_list_.AddHandler(
@@ -175,7 +175,7 @@ class ConfigurationPolicyPrefStoreRefreshTest
kTestPolicy, kTestPref, base::Value::TYPE_STRING)));
}
- virtual void TearDown() override {
+ void TearDown() override {
store_->RemoveObserver(&observer_);
ConfigurationPolicyPrefStoreTest::TearDown();
}

Powered by Google App Engine
This is Rietveld 408576698