components/password_manager/core/browser/password_store_default_unittest.cc - Issue 684513002: Standardize usage of virtual/override/final specifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_store_default_unittest.cc

Issue 684513002: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/password_manager_unittest.cc ('k') | components/password_manager/core/browser/password_store_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_store_default_unittest.cc

diff --git a/components/password_manager/core/browser/password_store_default_unittest.cc b/components/password_manager/core/browser/password_store_default_unittest.cc

index 2e1b2a6074add52ba4300bd8132ef93f677a0ba3..b0e7a7031ef438d479017337fddb79f4d55b511c 100644

--- a/components/password_manager/core/browser/password_store_default_unittest.cc

+++ b/components/password_manager/core/browser/password_store_default_unittest.cc

@@ -48,16 +48,14 @@ class MockPasswordStoreObserver : public PasswordStore::Observer {

class PasswordStoreDefaultTest : public testing::Test {

protected:

- virtual void SetUp() override {

+ void SetUp() override {

ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());

login_db_.reset(new LoginDatabase());

ASSERT_TRUE(login_db_->Init(temp_dir_.path().Append(

FILE_PATH_LITERAL("login_test"))));

}

- virtual void TearDown() override {

- ASSERT_TRUE(temp_dir_.Delete());

- }

+ void TearDown() override { ASSERT_TRUE(temp_dir_.Delete()); }

base::MessageLoopForUI message_loop_;

scoped_ptr<LoginDatabase> login_db_;