components/password_manager/content/renderer/credential_manager_client_browsertest.cc - Issue 684513002: Standardize usage of virtual/override/final specifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/content/renderer/credential_manager_client_browsertest.cc

Issue 684513002: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/content/browser/content_credential_manager_dispatcher_unittest.cc ('k') | components/password_manager/core/browser/login_database_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/content/renderer/credential_manager_client_browsertest.cc

diff --git a/components/password_manager/content/renderer/credential_manager_client_browsertest.cc b/components/password_manager/content/renderer/credential_manager_client_browsertest.cc

index ad35b1dfc4b5f09c182098741d3acb8f6f2c7c58..4d4de67204d199a21cf145746a3bdf37539224ed 100644

--- a/components/password_manager/content/renderer/credential_manager_client_browsertest.cc

+++ b/components/password_manager/content/renderer/credential_manager_client_browsertest.cc

@@ -20,15 +20,15 @@ class CredentialManagerClientTest : public content::RenderViewTest {

public:

CredentialManagerClientTest()

: callback_errored_(false), callback_succeeded_(false) {}

- virtual ~CredentialManagerClientTest() {}

+ ~CredentialManagerClientTest() override {}

- virtual void SetUp() override {

+ void SetUp() override {

content::RenderViewTest::SetUp();

credential_.reset(new blink::WebLocalCredential("", "", GURL(), ""));

client_.reset(new CredentialManagerClient(view_));

}

- virtual void TearDown() override {

+ void TearDown() override {

credential_.reset();

content::RenderViewTest::TearDown();

}