components/nacl/loader/nonsfi/nonsfi_sandbox.h - Issue 684513002: Standardize usage of virtual/override/final specifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/nacl/loader/nonsfi/nonsfi_sandbox.h

Issue 684513002: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/nacl/loader/nonsfi/nonsfi_main.cc ('k') | components/nacl/loader/sandbox_linux/nacl_bpf_sandbox_linux.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/nacl/loader/nonsfi/nonsfi_sandbox.h

diff --git a/components/nacl/loader/nonsfi/nonsfi_sandbox.h b/components/nacl/loader/nonsfi/nonsfi_sandbox.h

index 83efd7cbbfffa81f84bc5d95539be5626ab4f99d..2441ff3933f5f8196416c2304844db9cf92123e0 100644

--- a/components/nacl/loader/nonsfi/nonsfi_sandbox.h

+++ b/components/nacl/loader/nonsfi/nonsfi_sandbox.h

@@ -18,11 +18,10 @@ namespace nonsfi {

class NaClNonSfiBPFSandboxPolicy : public sandbox::bpf_dsl::Policy {

public:

explicit NaClNonSfiBPFSandboxPolicy() {}

- virtual ~NaClNonSfiBPFSandboxPolicy() {}

+ ~NaClNonSfiBPFSandboxPolicy() override {}

- virtual sandbox::bpf_dsl::ResultExpr EvaluateSyscall(

- int sysno) const override;

- virtual sandbox::bpf_dsl::ResultExpr InvalidSyscall() const override;

+ sandbox::bpf_dsl::ResultExpr EvaluateSyscall(int sysno) const override;

+ sandbox::bpf_dsl::ResultExpr InvalidSyscall() const override;

private:

DISALLOW_COPY_AND_ASSIGN(NaClNonSfiBPFSandboxPolicy);

« no previous file with comments | « components/nacl/loader/nonsfi/nonsfi_main.cc ('k') | components/nacl/loader/sandbox_linux/nacl_bpf_sandbox_linux.cc » ('j') | no next file with comments »