components/nacl/loader/nacl_ipc_adapter_unittest.cc - Issue 684513002: Standardize usage of virtual/override/final specifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/nacl/loader/nacl_ipc_adapter_unittest.cc

Issue 684513002: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/nacl/browser/pnacl_translation_cache_unittest.cc ('k') | components/nacl/loader/nacl_validation_query_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/nacl/loader/nacl_ipc_adapter_unittest.cc

diff --git a/components/nacl/loader/nacl_ipc_adapter_unittest.cc b/components/nacl/loader/nacl_ipc_adapter_unittest.cc

index 99f4638a485545edc9008a8bd527f3d94f9862c1..826b41d535d526c05a1e1a0a13eaccae88922ff4 100644

--- a/components/nacl/loader/nacl_ipc_adapter_unittest.cc

+++ b/components/nacl/loader/nacl_ipc_adapter_unittest.cc

@@ -24,7 +24,7 @@ class NaClIPCAdapterTest : public testing::Test {

NaClIPCAdapterTest() {}

// testing::Test implementation.

- virtual void SetUp() override {

+ void SetUp() override {

sink_ = new IPC::TestSink;

// Takes ownership of the sink_ pointer. Note we provide the current message

@@ -33,7 +33,7 @@ class NaClIPCAdapterTest : public testing::Test {

adapter_ = new NaClIPCAdapter(scoped_ptr<IPC::Channel>(sink_),

base::MessageLoopProxy::current().get());

}

- virtual void TearDown() override {

+ void TearDown() override {

sink_ = NULL; // This pointer is actually owned by the IPCAdapter.

adapter_ = NULL;

// The adapter destructor has to post a task to destroy the Channel on the