Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Unified Diff: components/keyed_service/content/browser_context_keyed_base_factory.h

Issue 684513002: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/keyed_service/content/browser_context_keyed_base_factory.h
diff --git a/components/keyed_service/content/browser_context_keyed_base_factory.h b/components/keyed_service/content/browser_context_keyed_base_factory.h
index c7603afd33e924d26ffeb1ec36622416aa12fb9c..f589e787f1bbbecc68ca0632541a7091a012c538 100644
--- a/components/keyed_service/content/browser_context_keyed_base_factory.h
+++ b/components/keyed_service/content/browser_context_keyed_base_factory.h
@@ -43,7 +43,7 @@ class KEYED_SERVICE_EXPORT BrowserContextKeyedBaseFactory
protected:
BrowserContextKeyedBaseFactory(const char* name,
BrowserContextDependencyManager* manager);
- virtual ~BrowserContextKeyedBaseFactory();
+ ~BrowserContextKeyedBaseFactory() override;
// Interface for people building a concrete FooServiceFactory: --------------
@@ -61,7 +61,7 @@ class KEYED_SERVICE_EXPORT BrowserContextKeyedBaseFactory
// TestingBrowserContext is NULL. (This is just a shortcut around
// SetTestingFactory() to make sure our contexts don't directly refer to the
// services they use.)
- virtual bool ServiceIsNULLWhileTesting() const override;
+ bool ServiceIsNULLWhileTesting() const override;
// Interface for people building a type of BrowserContextKeyedFactory: -------
@@ -102,17 +102,17 @@ class KEYED_SERVICE_EXPORT BrowserContextKeyedBaseFactory
virtual void CreateServiceNow(content::BrowserContext* context) = 0;
// KeyedServiceBaseFactory:
- virtual user_prefs::PrefRegistrySyncable* GetAssociatedPrefRegistry(
+ user_prefs::PrefRegistrySyncable* GetAssociatedPrefRegistry(
base::SupportsUserData* context) const final;
- virtual base::SupportsUserData* GetContextToUse(
+ base::SupportsUserData* GetContextToUse(
base::SupportsUserData* context) const final;
- virtual bool ServiceIsCreatedWithContext() const final;
- virtual void ContextShutdown(base::SupportsUserData* context) final;
- virtual void ContextDestroyed(base::SupportsUserData* context) final;
- virtual void RegisterPrefs(user_prefs::PrefRegistrySyncable* registry) final;
- virtual void SetEmptyTestingFactory(base::SupportsUserData* context) final;
- virtual bool HasTestingFactory(base::SupportsUserData* context) final;
- virtual void CreateServiceNow(base::SupportsUserData* context) final;
+ bool ServiceIsCreatedWithContext() const final;
+ void ContextShutdown(base::SupportsUserData* context) final;
+ void ContextDestroyed(base::SupportsUserData* context) final;
+ void RegisterPrefs(user_prefs::PrefRegistrySyncable* registry) final;
+ void SetEmptyTestingFactory(base::SupportsUserData* context) final;
+ bool HasTestingFactory(base::SupportsUserData* context) final;
+ void CreateServiceNow(base::SupportsUserData* context) final;
};
#endif // COMPONENTS_KEYED_SERVICE_CONTENT_BROWSER_CONTEXT_KEYED_BASE_FACTORY_H_

Powered by Google App Engine
This is Rietveld 408576698