components/invalidation/sync_system_resources_unittest.cc - Issue 684513002: Standardize usage of virtual/override/final specifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/invalidation/sync_system_resources_unittest.cc

Issue 684513002: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/invalidation/sync_invalidation_listener_unittest.cc ('k') | components/keyed_service/content/browser_context_dependency_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/invalidation/sync_system_resources_unittest.cc

diff --git a/components/invalidation/sync_system_resources_unittest.cc b/components/invalidation/sync_system_resources_unittest.cc

index ea2fb52e43bdf46c0faacae6c36c84faece786fd..3501f1eec3accad90fea2f11f9bb63f3168f88cc 100644

--- a/components/invalidation/sync_system_resources_unittest.cc

+++ b/components/invalidation/sync_system_resources_unittest.cc

@@ -54,7 +54,7 @@ class SyncSystemResourcesTest : public testing::Test {

scoped_ptr<notifier::PushClient>(new notifier::FakePushClient())),

sync_system_resources_(&push_client_channel_, &mock_state_writer_) {}

- virtual ~SyncSystemResourcesTest() {}

+ ~SyncSystemResourcesTest() override {}

void ScheduleShouldNotRun() {

{

@@ -212,9 +212,7 @@ class SyncNetworkChannelTest

this, &SyncNetworkChannelTest::OnNetworkStatusChange));

}

- virtual ~SyncNetworkChannelTest() {

- network_channel_.RemoveObserver(this);

- }

+ ~SyncNetworkChannelTest() override { network_channel_.RemoveObserver(this); }

void OnNetworkChannelStateChanged(

InvalidatorState invalidator_state) override {