Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Unified Diff: components/gcm_driver/gcm_driver_desktop_unittest.cc

Issue 684513002: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/gcm_driver/gcm_driver_desktop_unittest.cc
diff --git a/components/gcm_driver/gcm_driver_desktop_unittest.cc b/components/gcm_driver/gcm_driver_desktop_unittest.cc
index 8d9211bd7a75269d8549922d6b731c677f0cd3e6..7ccc5bd386e8683cfc211c62ac7779afdcd62814 100644
--- a/components/gcm_driver/gcm_driver_desktop_unittest.cc
+++ b/components/gcm_driver/gcm_driver_desktop_unittest.cc
@@ -99,11 +99,11 @@ class GCMDriverTest : public testing::Test {
};
GCMDriverTest();
- virtual ~GCMDriverTest();
+ ~GCMDriverTest() override;
// testing::Test:
- virtual void SetUp() override;
- virtual void TearDown() override;
+ void SetUp() override;
+ void TearDown() override;
GCMDriverDesktop* driver() { return driver_.get(); }
FakeGCMAppHandler* gcm_app_handler() { return gcm_app_handler_.get(); }
@@ -681,10 +681,10 @@ TEST_F(GCMDriverTest, GCMClientNotReadyBeforeSending) {
class GCMDriverFunctionalTest : public GCMDriverTest {
public:
GCMDriverFunctionalTest();
- virtual ~GCMDriverFunctionalTest();
+ ~GCMDriverFunctionalTest() override;
// GCMDriverTest:
- virtual void SetUp() override;
+ void SetUp() override;
private:
DISALLOW_COPY_AND_ASSIGN(GCMDriverFunctionalTest);
@@ -989,10 +989,10 @@ TEST_F(GCMDriverFunctionalTest, MessagesDeleted) {
class GCMChannelStatusSyncerTest : public GCMDriverTest {
public:
GCMChannelStatusSyncerTest();
- virtual ~GCMChannelStatusSyncerTest();
+ ~GCMChannelStatusSyncerTest() override;
// testing::Test:
- virtual void SetUp() override;
+ void SetUp() override;
void CompleteGCMChannelStatusRequest(bool enabled, int poll_interval_seconds);
bool CompareDelaySeconds(bool expected_delay_seconds,

Powered by Google App Engine
This is Rietveld 408576698