components/gcm_driver/gcm_client_impl_unittest.cc - Issue 684513002: Standardize usage of virtual/override/final specifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/gcm_driver/gcm_client_impl_unittest.cc

Issue 684513002: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/gcm_driver/gcm_channel_status_request_unittest.cc ('k') | components/gcm_driver/gcm_delayed_task_controller_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/gcm_driver/gcm_client_impl_unittest.cc

diff --git a/components/gcm_driver/gcm_client_impl_unittest.cc b/components/gcm_driver/gcm_client_impl_unittest.cc

index 9605cf0f29ea2036e8d5404f8748ac2f5f322865..d706276a3179321aa83956418c3e36284cf8fa95 100644

--- a/components/gcm_driver/gcm_client_impl_unittest.cc

+++ b/components/gcm_driver/gcm_client_impl_unittest.cc

@@ -236,9 +236,9 @@ class GCMClientImplTest : public testing::Test,

public GCMClient::Delegate {

public:

GCMClientImplTest();

- virtual ~GCMClientImplTest();

+ ~GCMClientImplTest() override;

- virtual void SetUp() override;

+ void SetUp() override;

void SetUpUrlFetcherFactory();

@@ -786,9 +786,9 @@ TEST_F(GCMClientImplTest, SendMessageAcknowledged) {

class GCMClientImplCheckinTest : public GCMClientImplTest {

public:

GCMClientImplCheckinTest();

- virtual ~GCMClientImplCheckinTest();

+ ~GCMClientImplCheckinTest() override;

- virtual void SetUp() override;

+ void SetUp() override;

};

GCMClientImplCheckinTest::GCMClientImplCheckinTest() {

@@ -1015,9 +1015,9 @@ TEST_F(GCMClientImplCheckinTest, CheckinWhenAccountReplaced) {

class GCMClientImplStartAndStopTest : public GCMClientImplTest {

public:

GCMClientImplStartAndStopTest();

- virtual ~GCMClientImplStartAndStopTest();

+ ~GCMClientImplStartAndStopTest() override;

- virtual void SetUp() override;

+ void SetUp() override;

void DefaultCompleteCheckin();

};