components/dom_distiller/core/dom_distiller_service_unittest.cc - Issue 684513002: Standardize usage of virtual/override/final specifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/dom_distiller/core/dom_distiller_service_unittest.cc

Issue 684513002: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/dom_distiller/core/distiller_url_fetcher_unittest.cc ('k') | components/dom_distiller/core/dom_distiller_store_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/dom_distiller/core/dom_distiller_service_unittest.cc

diff --git a/components/dom_distiller/core/dom_distiller_service_unittest.cc b/components/dom_distiller/core/dom_distiller_service_unittest.cc

index 4745c25c530e3488256662287462b02c4209f813..868b3983b91f351d15abb466435ec62128da81c3 100644

--- a/components/dom_distiller/core/dom_distiller_service_unittest.cc

+++ b/components/dom_distiller/core/dom_distiller_service_unittest.cc

@@ -79,7 +79,7 @@ scoped_ptr<DistilledArticleProto> CreateDefaultArticle() {

class DomDistillerServiceTest : public testing::Test {

public:

- virtual void SetUp() {

+ void SetUp() override {

main_loop_.reset(new base::MessageLoop());

FakeDB<ArticleEntry>* fake_db = new FakeDB<ArticleEntry>(&db_model_);

FakeDB<ArticleEntry>::EntryMap store_model;

@@ -96,7 +96,7 @@ class DomDistillerServiceTest : public testing::Test {

fake_db->LoadCallback(true);

}

- virtual void TearDown() {

+ void TearDown() override {

base::RunLoop().RunUntilIdle();

store_ = NULL;

distiller_factory_ = NULL;