components/data_reduction_proxy/core/browser/data_reduction_proxy_metrics_unittest.cc - Issue 684513002: Standardize usage of virtual/override/final specifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_metrics_unittest.cc

Issue 684513002: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_unittest.cc ('k') | components/data_reduction_proxy/core/browser/data_reduction_proxy_prefs_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_metrics_unittest.cc

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_metrics_unittest.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_metrics_unittest.cc

index 812aead4fb5475c6db38a52dfe82b6a087fc9329..b0b574df9c8c109f9c82a092d8a49545fbe3befc 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_metrics_unittest.cc

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_metrics_unittest.cc

@@ -40,7 +40,7 @@ class ChromeNetworkDataSavingMetricsTest : public testing::Test {

protected:

ChromeNetworkDataSavingMetricsTest() {}

- virtual void SetUp() override {

+ void SetUp() override {

statistics_prefs_.reset(new DataReductionProxyStatisticsPrefs(

&pref_service_,

scoped_refptr<base::TestSimpleTaskRunner>(

@@ -136,7 +136,7 @@ class ChromeNetworkDailyDataSavingMetricsTest

base::Time::FromString(kLastUpdateTime, &now_);

}

- virtual void SetUp() override {

+ void SetUp() override {

ChromeNetworkDataSavingMetricsTest::SetUp();

// Only create two lists in Setup to test that adding new lists is fine.