components/copresence/mediums/audio/audio_player_impl.h - Issue 684513002: Standardize usage of virtual/override/final specifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/copresence/mediums/audio/audio_player_impl.h

Issue 684513002: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/copresence/mediums/audio/audio_manager_unittest.cc ('k') | components/copresence/mediums/audio/audio_player_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/copresence/mediums/audio/audio_player_impl.h

diff --git a/components/copresence/mediums/audio/audio_player_impl.h b/components/copresence/mediums/audio/audio_player_impl.h

index 84e0753894018829fdff3ab2b97e92ed4901566a..b89eaa0bfb16907d5868db445ffe70d93ff972ad 100644

--- a/components/copresence/mediums/audio/audio_player_impl.h

+++ b/components/copresence/mediums/audio/audio_player_impl.h

@@ -46,7 +46,7 @@ class AudioPlayerImpl final

FRIEND_TEST_ALL_PREFIXES(AudioPlayerTest, BasicPlayAndStop);

FRIEND_TEST_ALL_PREFIXES(AudioPlayerTest, OutOfOrderPlayAndStopMultiple);

- virtual ~AudioPlayerImpl();

+ ~AudioPlayerImpl() override;

// Methods to do our various operations; all of these need to be run on the

// audio thread.