components/captive_portal/captive_portal_detector_unittest.cc - Issue 684513002: Standardize usage of virtual/override/final specifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/captive_portal/captive_portal_detector_unittest.cc

Issue 684513002: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/bookmarks/browser/bookmark_utils_unittest.cc ('k') | components/component_updater/test/component_patcher_unittest.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/captive_portal/captive_portal_detector_unittest.cc

diff --git a/components/captive_portal/captive_portal_detector_unittest.cc b/components/captive_portal/captive_portal_detector_unittest.cc

index 486baa145b7f7b4b5c78ba6f60b19c0231d40505..25eb35c1e373720d0e35e029a48cd23321d6246d 100644

--- a/components/captive_portal/captive_portal_detector_unittest.cc

+++ b/components/captive_portal/captive_portal_detector_unittest.cc

@@ -52,9 +52,9 @@ class CaptivePortalDetectorTest : public testing::Test,

public CaptivePortalDetectorTestBase {

public:

CaptivePortalDetectorTest() {}

- virtual ~CaptivePortalDetectorTest() {}

+ ~CaptivePortalDetectorTest() override {}

- virtual void SetUp() override {

+ void SetUp() override {

CHECK(base::MessageLoopProxy::current().get());

scoped_refptr<net::URLRequestContextGetter> request_context_getter(

new net::TestURLRequestContextGetter(

@@ -64,9 +64,7 @@ class CaptivePortalDetectorTest : public testing::Test,

set_detector(detector_.get());

}

- virtual void TearDown() override {

- detector_.reset();

- }

+ void TearDown() override { detector_.reset(); }

void RunTest(const CaptivePortalDetector::Results& expected_results,

int net_error,