Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Side by Side Diff: components/webdata/common/web_database_migration_unittest.cc

Issue 684513002: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/web_modal/web_contents_modal_dialog_manager_unittest.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <string> 5 #include <string>
6 6
7 #include "base/files/file_util.h" 7 #include "base/files/file_util.h"
8 #include "base/files/scoped_temp_dir.h" 8 #include "base/files/scoped_temp_dir.h"
9 #include "base/guid.h" 9 #include "base/guid.h"
10 #include "base/message_loop/message_loop.h" 10 #include "base/message_loop/message_loop.h"
(...skipping 152 matching lines...) Expand 10 before | Expand all | Expand 10 after
163 163
164 } // anonymous namespace 164 } // anonymous namespace
165 165
166 // The WebDatabaseMigrationTest encapsulates testing of database migrations. 166 // The WebDatabaseMigrationTest encapsulates testing of database migrations.
167 // Specifically, these tests are intended to exercise any schema changes in 167 // Specifically, these tests are intended to exercise any schema changes in
168 // the WebDatabase and data migrations that occur in 168 // the WebDatabase and data migrations that occur in
169 // |WebDatabase::MigrateOldVersionsAsNeeded()|. 169 // |WebDatabase::MigrateOldVersionsAsNeeded()|.
170 class WebDatabaseMigrationTest : public testing::Test { 170 class WebDatabaseMigrationTest : public testing::Test {
171 public: 171 public:
172 WebDatabaseMigrationTest() {} 172 WebDatabaseMigrationTest() {}
173 virtual ~WebDatabaseMigrationTest() {} 173 ~WebDatabaseMigrationTest() override {}
174 174
175 virtual void SetUp() { 175 void SetUp() override { ASSERT_TRUE(temp_dir_.CreateUniqueTempDir()); }
176 ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());
177 }
178 176
179 // Load the database via the WebDatabase class and migrate the database to 177 // Load the database via the WebDatabase class and migrate the database to
180 // the current version. 178 // the current version.
181 void DoMigration() { 179 void DoMigration() {
182 // TODO(joi): This whole unit test file needs to stay in //chrome 180 // TODO(joi): This whole unit test file needs to stay in //chrome
183 // for now, as it needs to know about all the different table 181 // for now, as it needs to know about all the different table
184 // types. Once all webdata datatypes have been componentized, this 182 // types. Once all webdata datatypes have been componentized, this
185 // could move to components_unittests. 183 // could move to components_unittests.
186 AutofillTable autofill_table("en-US"); 184 AutofillTable autofill_table("en-US");
187 KeywordTable keyword_table; 185 KeywordTable keyword_table;
(...skipping 2526 matching lines...) Expand 10 before | Expand all | Expand 10 after
2714 2712
2715 // Check version. 2713 // Check version.
2716 EXPECT_EQ(kCurrentTestedVersionNumber, VersionFromConnection(&connection)); 2714 EXPECT_EQ(kCurrentTestedVersionNumber, VersionFromConnection(&connection));
2717 2715
2718 EXPECT_FALSE(connection.DoesTableExist("web_apps")); 2716 EXPECT_FALSE(connection.DoesTableExist("web_apps"));
2719 EXPECT_FALSE(connection.DoesTableExist("web_app_icons")); 2717 EXPECT_FALSE(connection.DoesTableExist("web_app_icons"));
2720 EXPECT_FALSE(connection.DoesTableExist("web_intents")); 2718 EXPECT_FALSE(connection.DoesTableExist("web_intents"));
2721 EXPECT_FALSE(connection.DoesTableExist("web_intents_defaults")); 2719 EXPECT_FALSE(connection.DoesTableExist("web_intents_defaults"));
2722 } 2720 }
2723 } 2721 }
OLDNEW
« no previous file with comments | « components/web_modal/web_contents_modal_dialog_manager_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698