Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Side by Side Diff: components/nacl/browser/nacl_file_host_unittest.cc

Issue 684513002: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/nacl/browser/nacl_file_host.h" 5 #include "components/nacl/browser/nacl_file_host.h"
6 6
7 #include "base/basictypes.h" 7 #include "base/basictypes.h"
8 #include "base/files/file_path.h" 8 #include "base/files/file_path.h"
9 #include "base/files/scoped_temp_dir.h" 9 #include "base/files/scoped_temp_dir.h"
10 #include "base/test/scoped_path_override.h" 10 #include "base/test/scoped_path_override.h"
(...skipping 17 matching lines...) Expand all
28 pnacl_path_ = pnacl_dir; 28 pnacl_path_ = pnacl_dir;
29 } 29 }
30 30
31 private: 31 private:
32 base::FilePath pnacl_path_; 32 base::FilePath pnacl_path_;
33 }; 33 };
34 34
35 class NaClFileHostTest : public testing::Test { 35 class NaClFileHostTest : public testing::Test {
36 protected: 36 protected:
37 NaClFileHostTest(); 37 NaClFileHostTest();
38 virtual ~NaClFileHostTest(); 38 ~NaClFileHostTest() override;
39 39
40 virtual void SetUp() override { 40 void SetUp() override {
41 nacl_browser_delegate_ = new FileHostTestNaClBrowserDelegate; 41 nacl_browser_delegate_ = new FileHostTestNaClBrowserDelegate;
42 nacl::NaClBrowser::SetDelegate(nacl_browser_delegate_); 42 nacl::NaClBrowser::SetDelegate(nacl_browser_delegate_);
43 } 43 }
44 44
45 virtual void TearDown() override { 45 void TearDown() override {
46 // This deletes nacl_browser_delegate_. 46 // This deletes nacl_browser_delegate_.
47 nacl::NaClBrowser::SetDelegate(NULL); 47 nacl::NaClBrowser::SetDelegate(NULL);
48 } 48 }
49 49
50 FileHostTestNaClBrowserDelegate* nacl_browser_delegate() { 50 FileHostTestNaClBrowserDelegate* nacl_browser_delegate() {
51 return nacl_browser_delegate_; 51 return nacl_browser_delegate_;
52 } 52 }
53 53
54 private: 54 private:
55 FileHostTestNaClBrowserDelegate* nacl_browser_delegate_; 55 FileHostTestNaClBrowserDelegate* nacl_browser_delegate_;
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
110 EXPECT_FALSE(PnaclCanOpenFile("..\\llc", &out_path)); 110 EXPECT_FALSE(PnaclCanOpenFile("..\\llc", &out_path));
111 EXPECT_FALSE(PnaclCanOpenFile("%SystemRoot%", &out_path)); 111 EXPECT_FALSE(PnaclCanOpenFile("%SystemRoot%", &out_path));
112 EXPECT_FALSE(PnaclCanOpenFile("%SystemRoot%\\explorer.exe", &out_path)); 112 EXPECT_FALSE(PnaclCanOpenFile("%SystemRoot%\\explorer.exe", &out_path));
113 #else 113 #else
114 EXPECT_FALSE(PnaclCanOpenFile("../llc", &out_path)); 114 EXPECT_FALSE(PnaclCanOpenFile("../llc", &out_path));
115 EXPECT_FALSE(PnaclCanOpenFile("/bin/sh", &out_path)); 115 EXPECT_FALSE(PnaclCanOpenFile("/bin/sh", &out_path));
116 EXPECT_FALSE(PnaclCanOpenFile("$HOME", &out_path)); 116 EXPECT_FALSE(PnaclCanOpenFile("$HOME", &out_path));
117 EXPECT_FALSE(PnaclCanOpenFile("$HOME/.bashrc", &out_path)); 117 EXPECT_FALSE(PnaclCanOpenFile("$HOME/.bashrc", &out_path));
118 #endif 118 #endif
119 } 119 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698